fix warnings #37
Open
fix warnings #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1adad9 to
0d52596
Compare
Ignore IntelliJ and whatsapp_backup
Sonarlint pythonS1515 Warning was: Add a parameter to the parent lambda function and use variable "message" as its default value; The value of "message" might change at the next loop iteration.
Sonarlint python:S112 Replace this generic exception class with a more specific one.
Is int in tests and on real data too.
Is int in tests and on real data too.
In the sqlite db chat._id is an integer
In the sqlite message.chat_row_id is an integer
So `--backup_specific_or_all_chat_call all` works
1a5bb92 to
12b3e31
Compare
|
Rebased on main branch to fix merge conflicts from PR #36 "Write files in UTF-8" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Saurabh
The utf8 PR #36 is really a problem when on Windows.
This PR here has my the small fixes for warnings by IntelliJ/SonarLint.
Use what you like.
Thanks for this project!
p.s.
I renamed some branches after opening PRs on them. Sry for the noise or any extra emails.