Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip interface with shokunin sim #145

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dexairob
Copy link

Background

[Describe the background for this PR here.
Edit this description and all other fields in square brackets. When you see ✅❌, it means selection between two choices. Leave the ❌ next to ✅ in place until the item is fully resolved, or keep the ❌ only to indicate N/A.]

What's new

  • ✅ [New feature description. Only a single new major feature is allowed per PR.]
  • ✅❌ New feature is accompanied by new test: [name and description of new test].

Related work

  • ✅❌ This PR needs [link]
  • ✅❌ [link] needs this PR

TODOs / Nice-To-Haves

  • ❌ [Add new unit test for new feature.]
  • ❌ [Add new system test for new feature.]

Tests

  1. ✅❌ Tested on simulated robot: [Describe the tests/commands used.]
  2. ✅❌ Tested on physical robot: [Describe the tests/commands used.]

Quality

  1. ✅❌ New code is written in pure C++17 to the best of my knowledge.
  2. ✅❌ New code follows established C++17 best practices (C++ Core Guidelines).
  3. ✅❌ New code passed clang-format and cpplint at least, if not all of our static code analysers.
  4. ✅❌ I have included Doxygen-style documentation in the new C++ code.

Note to reviewers

Please verify that all sections are accurately filled out and that all 6 numbered entries above are present and ticked/checked off, with their requirements met, if applicable.

@dexairob dexairob force-pushed the rt.shokunin_sim_interface.v1 branch from 75c21d0 to 9332097 Compare April 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant