This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
add new indicator for talib "WILLR - Williams' %R with rsi oversold", "ADOSC - Chaikin A/D Oscillator" with rsi oversold with support for all volume based indicator #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystophv
reviewed
Feb 17, 2018
lib/ta_volume.js
Outdated
| return | ||
| } | ||
|
|
||
| let tmpHigh = JSON.parse(JSON.stringify(s.marketData.high)) |
There was a problem hiding this comment.
The JSON stringify/parse is an incredibly slow way to make an array copy. Please consider array.slice(0) instead. array.slice() documentation Benchmark: http://jsben.ch/dzO4U
There was a problem hiding this comment.
thx for this input done
… "ADOSC - Chaikin A/D Oscillator" with rsi oversold with support for all volume based indicator
0a54adb to
ae301ba
Compare
This was referenced Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some more indicator, still no strategy because they need some combinations for a suitable outcome