Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unpack macro and pass rng #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Tortar
Copy link

@Tortar Tortar commented Mar 9, 2025

Nice package @Devetak! I was taking a look at the code and I have compacted it a bit with the unpack macro and accepted a namedtuple which is less error prone, and, most importantly, setting the seed from inside a function is dangerous because you can end then have the default rng of julia to have that seed which can cause confusion e.g. before

julia> Mark0.mark0_noCB(Mark0.getParameters(), 10, 10, 1)
1-element Vector{Float64}:
 0.4996975599347817

julia> rand()
0.06236226260683142 # always the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant