Add store's action queue state on ViewStore and modify private only setter

[sobabear]

Related Issues 💭

I have two suggestion's for ViewStore.

One is making a limitation for allowing setter on public.
The other one is let viewstore be able to know of store's state, especially actionQueue.

Description 📝

Additional Notes 📚

Checklist ✅

• If the changes affect existing functionality, please verify whether the above information has been appropriately described.

[DevYeom]

What you first suggested was necessary. Thanks!
However, I don't understand the need for your second suggestion about actionQueue and isProcessing. Could you explain why it is needed?

Note

Directly modifying the state of the store can lead to unintended side effects and is considered an anti-pattern. It is preferable to change the state only by calling send().

[sobabear]

@DevYeom
Thanks to reply!

The reason of second one, just my opinion, is that i thought Combination with 'queue-based' system and Unidirectional system could be let know developers proper informations of state.

I already know Store does automatically manage actions(queue based) so user(developer) does not need to handle it at all. Moreover some syntax shall help it such as states: AsyncStream. On the others hands when handle very long timed action (which let store is on processing and actionqueue is not empty), it would be very helpful to developer to know least information of store's state

[DevYeom]

Your second suggestion also makes sense. However, There is a way to find out if a long-duration action is being processed could be as follows.

func reduce(state: inout State, action: Action) -> AnyEffect<Action> {
// ...
    case .request:
        return .concat(
            .just(.setIsLoading(true)),
            .single {
                let result = await longTimeAPI.request()
                return .response(result)
            },
            .just(.setIsLoading(false))
        )
    case .setIsLoading(let isLoading):
        state.isLoading = isLoading
        return .none
    }
// ...
}

I also have a plan to support a debug print feature(e.g. printing changes in state to the console). I hope you understand that I try not to expose the interface externally(public) as much as possible to reduce misuse.

How about only including the first suggestion this time?

[sobabear]

Your second suggestion also makes sense. However, There is a way to find out if a long-duration action is being processed could be as follows.

func reduce(state: inout State, action: Action) -> AnyEffect<Action> {
// ...
    case .request:
        return .concat(
            .just(.setIsLoading(true)),
            .single {
                let result = await longTimeAPI.request()
                return .response(reulst)
            },
            .just(.setIsLoading(false))
        )
    case .setIsLoading(let isLoading):
        state.isLoading = isLoading
        return .none
    }
// ...
}

I also have a plan to support a debug print feature(e.g. printing changes in state to the console). I hope you understand that I try not to expose the interface externally(public) as much as possible to reduce misuse.

How about only including the first suggestion this time?

Very acceptable decision! Please check it out! @DevYeom

[DevYeom]

Thanks!