Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing swift build for linux ci #104

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Add missing swift build for linux ci #104

merged 2 commits into from
Oct 14, 2024

Conversation

sobabear
Copy link
Contributor

Description 📝

OneWay is a swift library for state management regardless of platforms even if it is not contains apple enviroment. As Swift and Foundation became as an open source. Compilable and runnable on linux would get mattering. Thus validating build before merge can be very important

I personally had experienced swift-foundation's missing function which is not building on linux even working on macos. Moreover as introducing Concurrency, Foundation has got missing more and more refactored-async-concurrency methods. For in my case, Foundation missed URLSession's concurrency function.

As OneWay's main is concurrency, I think build-checking is crucial so I suggest swift build not only testing

Copy link
Owner

@DevYeom DevYeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extend the timeout of StoreTests.test_lotsOfActions to 10 seconds to resolve the CI failure?

The time it takes may vary depending on the machine's performance. It seems that there may have been a change to the linux machine.

Makefile Outdated Show resolved Hide resolved
@sobabear
Copy link
Contributor Author

@DevYeom Seems like passed!

Copy link
Owner

@DevYeom DevYeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DevYeom DevYeom merged commit c83249b into DevYeom:main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants