Feature/report #11
Merged
Feature/report #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since1909
reviewed
Oct 30, 2024
| package org.devpalsboot.report.domain; | ||
|
|
||
| import org.devpalsboot.report.ReportStatus; | ||
| public record ReportComplete (String objectPath, ReportStatus status) |
There was a problem hiding this comment.
status 값에 따라 objectPath 파라미터가 null 이 될 수도 있을 거 같은데 이와 같은 케이스에 대해서도 정의해보면 좋을 거 같습니다.
since1909
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
보고서 생성 완료 후 전달해야 하는 정보를 선별하였고 아래와 같습니다.
이를 기반으로, 해당 정보를 담은 ReportComplete 클래스를 record 타입으로 생성하였습니다.
보고서 생성이 완료되면 objectPath와 status는 변경되지 않으므로, 불변성을 보장하기 위해 record 타입을 선택하였습니다.