Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

백엔드 모듈 produce, consume 로직 추가 #10

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

since1909
Copy link
Member

  • backend 모듈 카프카 연결 설정 추가
  • backend REPORT_CREATION 메시지 발행 (producer)
  • backend REPORT_COMPLETE 메시지 구독 (consumer)

@since1909 since1909 added the enhancement New feature or request label Oct 29, 2024
@since1909 since1909 added this to the V1.0.0 milestone Oct 29, 2024
@since1909 since1909 requested a review from suna-ji October 29, 2024 05:26
Copy link
Member

@suna-ji suna-ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료했습니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controller, service 구조로 나누지 않고 consumer, producer 패키지 구조로 나눈 이유가 있을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재는 아키텍처 구조상 메시지 발행, 소비가 각 모듈마다 있기 때문에 그 주체를 더 직관적이라고 표현하기 위해 이렇게 나눴습니다!
실제 서비스 도입에서도 각 서비스에서의 발행과 소비 주체를 명확하게 하기 위한 패키지 구조에 대해서 고민해보면 좋을거 같습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메소드명이 직관적이라 읽기 편합니다.

@suna-ji suna-ji merged commit a4b9f26 into main Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants