This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Start telemetry earlier and add a timeout #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DS-263 Telemetry: background it and add a timeout
Let's try to avoid blocking exiting the program on telemetry. If we are blocking on telemetry, let's keep it from taking any more than 250ms. |
742330e to
37d5d1d
Compare
grahamc
reviewed
Aug 24, 2022
Hoverbear
commented
Aug 24, 2022
cole-h
reviewed
Aug 24, 2022
src/dependency_registry/mod.rs
Outdated
| @@ -1,3 +1,8 @@ | |||
| use crate::{ | |||
There was a problem hiding this comment.
Extremely nit-picky, so feel free to ignore, but it'd be swell to group std, external, and internal imports near each-other
There was a problem hiding this comment.
There is a rustfmt setting if I recall...
There was a problem hiding this comment.
There is, but it's not stabilized, sadly: https://rust-lang.github.io/rustfmt/?version=v1.5.1&search=#group_imports, rust-lang/rustfmt#5083.
grahamc
reviewed
Aug 25, 2022
Hoverbear
commented
Aug 25, 2022
| } else { | ||
| tracing::trace!("Fetching new registry data from {DEPENDENCY_REGISTRY_REMOTE_URL}"); | ||
| } | ||
| let req = http_client.get(DEPENDENCY_REGISTRY_REMOTE_URL); |
There was a problem hiding this comment.
At the moment this has default timeout as the process will end without blocking if it's held up.
cole-h
approved these changes
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based off #52 )