shutdown: wait for flakehub_cache first #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3dffd0 to
c06acdd
Compare
grahamc
reviewed
Nov 5, 2024
magic-nix-cache/src/api.rs
Outdated
| .join(", ") | ||
| ); | ||
| } else { | ||
| tracing::info!("NOT Waiting for FlakeHub cache uploads to finish"); |
There was a problem hiding this comment.
Suggested change
| tracing::info!("NOT Waiting for FlakeHub cache uploads to finish"); | |
| tracing::info!("FlakeHub cache is not enabled, not uploading anything to it"); |
grahamc
reviewed
Nov 5, 2024
magic-nix-cache/src/api.rs
Outdated
| let paths = attic_state.push_session.wait().await?; | ||
|
|
||
| tracing::info!( | ||
| "Waited for FlakeHub cache upload. Uploaded: {}", |
There was a problem hiding this comment.
Suggested change
| "Waited for FlakeHub cache upload. Uploaded: {}", | |
| "FlakeHub Cache uploads completed. Uploaded: {}", |
grahamc
approved these changes
Nov 5, 2024
c06acdd to
67b2b68
Compare
67b2b68 to
625d771
Compare
grahamc
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.