double click to insert inlay hints #968

DetachHead · 2024-12-25T08:50:28Z

fixes #198

… from the same module but it didn't work

…g an inlay hint

…ins `None`

…port comes from the current module, that doesn't rely on a venv

packages/pyright-internal/src/tests/typeInlayHintsWalker.test.ts

…ther cases

…on the python version

github-actions · 2025-01-26T14:16:29Z

Diff from mypy_primer, showing the effect of this PR on open source code:

sympy (https://github.com/sympy/sympy)
-     Type of "constant_renumber" is "(expr: Unknown, variables: Unknown | None = None, newconstants: Unknown | None = None) -> (list[Unknown] | set[Unknown] | tuple[Unknown, ...] | Boolean | Basic | Unknown)" (reportUnknownVariableType)
+     Type of "constant_renumber" is "(expr: Unknown, variables: Unknown | None = None, newconstants: Unknown | None = None) -> (list[Unknown] | set[Unknown] | tuple[Unknown, ...] | Boolean | Expr | Basic | Unknown)" (reportUnknownVariableType)
-     Type of "i" is "Equality | Unknown" (reportUnknownVariableType)
+     Type of "i" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
-     Type of "decompogen" is "(f: Unknown, symbol: Unknown) -> (list[Expr] | list[Function | Pow] | list[Expr | Basic] | list[Function | Pow | Basic] | Unknown | list[Min | Max | Basic] | list[Unknown | Max | Min | Basic] | list[Basic] | list[Unknown | Poly | Basic] | list[Min | Max] | list[Unknown | Max | Min] | list[Unknown] | list[Unknown | Poly])" (reportUnknownVariableType)
+     Type of "decompogen" is "(f: Unknown, symbol: Unknown) -> (list[Expr] | list[Function | Pow] | list[Expr | Basic] | list[Function | Pow | Basic] | Unknown | list[Min | Max | Basic] | list[Unknown | Max | Min | Basic] | list[Basic] | list[Expr | Unknown | Basic] | list[Unknown | Poly | Basic] | list[Min | Max] | list[Unknown | Max | Min] | list[Expr | Unknown] | list[Unknown | Poly])" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_decompogen.py:23:31 - warning: Return type of lambda, "list[Expr] | list[Function | Pow] | list[Expr | Basic] | list[Function | Pow | Basic] | Unknown | list[Min | Max | Basic] | list[Unknown | Max | Min | Basic] | list[Basic] | list[Unknown | Poly | Basic] | list[Min | Max] | list[Unknown | Max | Min] | list[Unknown] | list[Unknown | Poly]", is partially unknown (reportUnknownLambdaType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_decompogen.py:23:31 - warning: Return type of lambda, "list[Expr] | list[Function | Pow] | list[Expr | Basic] | list[Function | Pow | Basic] | Unknown | list[Min | Max | Basic] | list[Unknown | Max | Min | Basic] | list[Basic] | list[Expr | Unknown | Basic] | list[Unknown | Poly | Basic] | list[Min | Max] | list[Unknown | Max | Min] | list[Expr | Unknown] | list[Unknown | Poly]", is partially unknown (reportUnknownLambdaType)
-     Type of "rootof" is "(f: Unknown, x: Unknown, index: Unknown | None = None, radicals: bool = True, expand: bool = True) -> (Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | _NotImplementedType | Expr)" (reportUnknownVariableType)
+     Type of "rootof" is "(f: Unknown, x: Unknown, index: Unknown | None = None, radicals: bool = True, expand: bool = True) -> (Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Expr)" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:134:9 - warning: Type of "inf" is partially unknown
+     Type of "inf" is "One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Unknown" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:137:16 - warning: Argument type is partially unknown
-     Argument corresponds to parameter "args" in function "__new__"
-     Argument type is "Equality | Unknown" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:137:16 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "args" of type "Boolean | bool" in function "__new__"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Boolean | bool"
+       Type "Integer" is not assignable to type "Boolean | bool"
+         "Integer" is not assignable to "Boolean"
+         "Integer" is not assignable to "bool" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:137:29 - warning: Argument type is partially unknown
-     Argument corresponds to parameter "args" in function "__new__"
-     Argument type is "Equality | Unknown" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:137:29 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "args" of type "Boolean | bool" in function "__new__"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Boolean | bool"
+       Type "Integer" is not assignable to type "Boolean | bool"
+         "Integer" is not assignable to "Boolean"
+         "Integer" is not assignable to "bool" (reportArgumentType)
-     Type of "e" is "Equality | Unknown | NaN | Sum" (reportUnknownVariableType)
+     Type of "e" is "Equality | Unknown | Relational | Unequality | Integer | NaN | Sum" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:287:12 - warning: Argument type is partially unknown
-     Argument corresponds to parameter "args" in function "__new__"
-     Argument type is "Equality | Unknown" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:287:12 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "args" of type "Boolean | bool" in function "__new__"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Boolean | bool"
+       Type "Integer" is not assignable to type "Boolean | bool"
+         "Integer" is not assignable to "Boolean"
+         "Integer" is not assignable to "bool" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:287:22 - warning: Argument type is partially unknown
-     Argument corresponds to parameter "args" in function "__new__"
-     Argument type is "Equality | Unknown" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:287:22 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "args" of type "Boolean | bool" in function "__new__"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Boolean | bool"
+       Type "Integer" is not assignable to type "Boolean | bool"
+         "Integer" is not assignable to "Boolean"
+         "Integer" is not assignable to "bool" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:297:79 - warning: Argument type is partially unknown
-     Argument corresponds to parameter "args" in function "__new__"
-     Argument type is "Equality | Unknown" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:297:79 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "args" of type "Boolean | bool" in function "__new__"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Boolean | bool"
+       Type "Integer" is not assignable to type "Boolean | bool"
+         "Integer" is not assignable to "Boolean"
+         "Integer" is not assignable to "bool" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:297:89 - warning: Argument type is partially unknown
-     Argument corresponds to parameter "args" in function "__new__"
-     Argument type is "Equality | Unknown" (reportUnknownArgumentType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:297:89 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "args" of type "Boolean | bool" in function "__new__"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Boolean | bool"
+       Type "Integer" is not assignable to type "Boolean | bool"
+         "Integer" is not assignable to "Boolean"
+         "Integer" is not assignable to "bool" (reportArgumentType)
-     Type of "r" is "Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | _NotImplementedType | Expr" (reportUnknownVariableType)
+     Type of "r" is "Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Expr" (reportUnknownVariableType)
-     Type of "ie" is "Equality | Unknown" (reportUnknownVariableType)
+     Type of "ie" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:459:13 - warning: Type of "e" is partially unknown
+     Type of "e" is "Any | _NotImplementedType | StrictGreaterThan | Unknown | Equality | Relational | Unequality | Integer" (reportUnknownVariableType)
-     Type of "e" is "Equality | Unknown" (reportUnknownVariableType)
+     Type of "e" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
-     Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
+     Type of "eq" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
-     Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
+     Type of "eq" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)
-     Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
+     Type of "eq" is "Equality | Unknown | Relational | Unequality | Integer" (reportUnknownVariableType)

... (truncated 5115 lines) ...

arviz (https://github.com/arviz-devs/arviz): 5.73x slower (5.7s -> 32.8s in a single noisy sample)

gsiddhant159 · 2025-01-31T05:08:07Z

Hi, I am using basedpyright 1.26 in neovim 10.4
Is there any docs on a public function/ language server setting to allow implementing this in neovim?

DetachHead · 2025-01-31T05:17:55Z

i'm not sure whether neovim supports it, i guess you'd have to ask the maintainers of neovim

DetachHead force-pushed the inlay-hint-stuff branch 3 times, most recently from b53f178 to 9be6034 Compare January 12, 2025 03:35

DetachHead changed the title ~~inlay hint stuff~~ double click to insert inlay hints Jan 12, 2025

DetachHead marked this pull request as ready for review January 12, 2025 03:37

DetachHead force-pushed the inlay-hint-stuff branch from 9be6034 to 7de806b Compare January 12, 2025 03:39

This comment has been minimized.

Sign in to view

DetachHead force-pushed the inlay-hint-stuff branch from 3e45102 to a9c1f65 Compare January 13, 2025 07:42

This comment has been minimized.

Sign in to view

DetachHead force-pushed the inlay-hint-stuff branch from a9c1f65 to e611b2a Compare January 13, 2025 09:25

This comment has been minimized.

Sign in to view

DetachHead added 7 commits January 26, 2025 12:35

double click to insert inlay hints

f7cc3cc

refactor the inlay hint import tracker in an attempt to group imports…

c06ff87

… from the same module but it didn't work

use getOrAdd util function in ImportTracker

7d40020

prevent imports from the current file being added when double clickin…

9f1e9f9

…g an inlay hint

fix inlay hint tests and use typed-jest-expect because jest sucks

5bdd29f

fix NoneType being imported when accepting an inlay hint that conta…

f9e0798

…ins `None`

use a different method in ImportTracker to determine whether the im…

63b2624

…port comes from the current module, that doesn't rely on a venv

DetachHead force-pushed the inlay-hint-stuff branch from 874d969 to de7ed79 Compare January 26, 2025 09:16

DetachHead commented Jan 26, 2025

View reviewed changes

packages/pyright-internal/src/tests/typeInlayHintsWalker.test.ts Show resolved Hide resolved

packages/pyright-internal/src/tests/typeInlayHintsWalker.test.ts Show resolved Hide resolved

group multiple imports from the same module when inserting inlay hints

4deb887

This comment has been minimized.

Sign in to view

DetachHead force-pushed the inlay-hint-stuff branch from de7ed79 to df29c3c Compare January 26, 2025 10:36

fix Callable not being imported when inserting inlay hints + some o…

565d0e9

…ther cases

DetachHead force-pushed the inlay-hint-stuff branch from df29c3c to 565d0e9 Compare January 26, 2025 10:45

This comment has been minimized.

Sign in to view

fix inlay hint insertions for typing/typing_extensions depending …

723e70a

…on the python version

DetachHead merged commit 9f552b9 into main Jan 26, 2025
20 checks passed

DetachHead deleted the inlay-hint-stuff branch January 26, 2025 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

double click to insert inlay hints #968

double click to insert inlay hints #968

DetachHead commented Dec 25, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 26, 2025

gsiddhant159 commented Jan 31, 2025

DetachHead commented Jan 31, 2025

double click to insert inlay hints #968

double click to insert inlay hints #968

Conversation

DetachHead commented Dec 25, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 26, 2025

gsiddhant159 commented Jan 31, 2025

DetachHead commented Jan 31, 2025

DetachHead commented Dec 25, 2024 •

edited

Loading