Browser support #514

DetachHead · 2024-07-22T12:47:30Z

doesn't address #295, this is only for the playground

I've seen it give syntax errors and basic completions. No types are available except the one that I've rammed into the file system as a proof of concept. There are a couple of changes outside of the new package that need some careful consideration. Lots could be broken here as a variety of NodeJS modules have been stubbed out or polyfilled.

Config loading does use the fs abstraction but not for the cwd. We don't care so default it.

Reducing the diff between this and server.ts.

It's a syntax error so immediately scuppers things for Safari. This seems to be sufficient to get it running. Minimal testing so far but a big step forward. This specific change seems safe and well tested.

Uses an abstraction over Web Workers and worker_threads. A bit of a pain due to transferList. It requires a bit of a dance to create the Workers, particularly as Safari has no nested worker support. Browser clients will need updating to the new incantation. Also adds minimal file system operations. These are a stop-gap solution.

Interesting to see the import resolver hook and the nascent host abstraction.

Update from upstream. Align URI parsing in browser-server.ts with corresponding changes to server.ts (we have several more occurrences in our added FS APIs).

…r' into browser # Conflicts: # packages/pyright-internal/jest.config.js # packages/pyright-internal/src/analyzer/backgroundAnalysisProgram.ts # packages/pyright-internal/src/analyzer/sourceFile.ts # packages/pyright-internal/src/backgroundAnalysis.ts # packages/pyright-internal/src/backgroundAnalysisBase.ts # packages/pyright-internal/src/backgroundThreadBase.ts # packages/pyright-internal/src/languageServerBase.ts

…out and it works at runtime

…atch the other packages

# Conflicts: # packages/pyright-internal/src/analyzer/cacheManager.ts

github-actions · 2024-08-06T12:13:06Z

Diff from mypy_primer, showing the effect of this PR on open source code:

sympy (https://github.com/sympy/sympy)
-     Type of "P" is "(condition: Unknown, given_condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Any | BernoulliDistribution | Probability | Self@Expr | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Lambda | int | None)" (reportUnknownVariableType)
+     Type of "P" is "(condition: Unknown, given_condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Any | BernoulliDistribution | Probability | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Lambda | Relational | Unequality | int | None)" (reportUnknownVariableType)
-     Type of "E" is "(expr: Unknown, condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Basic | Expectation | tuple[Unknown, ...] | Sum | Self@Expr | Order | Any | Piecewise | Equality | Relational | Unequality | Integral | ExpectationMatrix | None)" (reportUnknownVariableType)
+     Type of "E" is "(expr: Unknown, condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Basic | Expectation | tuple[Unknown, ...] | Sum | Order | Any | Piecewise | Equality | Relational | Unequality | Integral | ExpectationMatrix | None)" (reportUnknownVariableType)
-     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
+     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
-     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
+     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:39:12 - error: Operator "-" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Any | Unknown | Expr | int"
+   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:39:12 - error: Operator "-" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Any | Unknown | Expr | int"
-     Operator "-" not supported for types "Expr*" and "Expr"
-     Operator "-" not supported for types "Expr*" and "int"
+     Operator "-" not supported for types "None" and "Expr"
+     Operator "-" not supported for types "None" and "int"
-     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
+     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:39:37 - error: Operator "**" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Literal[2]"
+   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:39:37 - error: Operator "**" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Literal[2]"
-     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
+     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
-     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
+     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:69:12 - error: Operator "-" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Any | Unknown | Expr | int"
+   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:69:12 - error: Operator "-" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Any | Unknown | Expr | int"
-     Operator "-" not supported for types "Expr*" and "Expr"
-     Operator "-" not supported for types "Expr*" and "int"
+     Operator "-" not supported for types "None" and "Expr"
+     Operator "-" not supported for types "None" and "int"
-     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
+     Type of "expectation" is "(expr: Unknown, var: Unknown, evaluate: bool = True, **kwargs: Unknown) -> (Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None)" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:69:37 - error: Operator "**" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Self@Expr | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Literal[2]"
+   /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_discrete_rv.py:69:37 - error: Operator "**" not supported for types "Any | Unknown | tuple[Unknown, ...] | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Literal[0] | None" and "Literal[2]"
-     Type of "rewrite" is "Unknown | Any | ((..., deep: bool = True) -> (BernoulliDistribution | Any)) | ((..., deep: bool = True) -> (Probability | Any)) | ((..., deep: bool = True) -> (Self@Expr | Any)) | ((..., deep: bool = True) -> (Sum | Any)) | ((..., deep: bool = True) -> (Order | Any)) | ((..., deep: bool = True) -> (Piecewise | Any)) | ((..., deep: bool = True) -> (Basic | Any)) | ((..., deep: bool = True) -> (Equality | Any)) | ((..., deep: bool = True) -> (Relational | Any)) | ((..., deep: bool = True) -> (Unequality | Any)) | ((..., deep: bool = True) -> (Lambda | Any))" (reportUnknownMemberType)
+     Type of "rewrite" is "Unknown | Any | ((..., deep: bool = True) -> (BernoulliDistribution | Any)) | ((..., deep: bool = True) -> (Probability | Any)) | ((..., deep: bool = True) -> (Sum | Any)) | ((..., deep: bool = True) -> (Order | Any)) | ((..., deep: bool = True) -> (Piecewise | Any)) | ((..., deep: bool = True) -> (Basic | Any)) | ((..., deep: bool = True) -> (Equality | Any)) | ((..., deep: bool = True) -> (Lambda | Any)) | ((..., deep: bool = True) -> (Relational | Any)) | ((..., deep: bool = True) -> (Unequality | Any))" (reportUnknownMemberType)
-     Argument type is "BernoulliDistribution | Any | Probability | Self@Expr | Sum | Order | Piecewise | Basic | Equality | Relational | Unequality | Lambda | Unknown" (reportUnknownArgumentType)
+     Argument type is "BernoulliDistribution | Any | Probability | Sum | Order | Piecewise | Basic | Equality | Lambda | Relational | Unequality | Unknown" (reportUnknownArgumentType)
-     Type of "rewrite" is "Unknown | Any | ((..., deep: bool = True) -> (BernoulliDistribution | Any)) | ((..., deep: bool = True) -> (Probability | Any)) | ((..., deep: bool = True) -> (Self@Expr | Any)) | ((..., deep: bool = True) -> (Sum | Any)) | ((..., deep: bool = True) -> (Order | Any)) | ((..., deep: bool = True) -> (Piecewise | Any)) | ((..., deep: bool = True) -> (Basic | Any)) | ((..., deep: bool = True) -> (Equality | Any)) | ((..., deep: bool = True) -> (Relational | Any)) | ((..., deep: bool = True) -> (Unequality | Any)) | ((..., deep: bool = True) -> (Lambda | Any))" (reportUnknownMemberType)

... (truncated 758 lines) ...

microbit-matt-hillsdon and others added 17 commits August 4, 2021 13:42

Remove irrelevant bin section.

e1cdc7f

Custom notification to bootstrap stubs/typeshed.

2ef4566

Simplify.

62306ec

Config loading does use the fs abstraction but not for the cwd. We don't care so default it.

Renames.

e04bc72

Temporarily use a hash in the filename.

3258a4b

Remove another hack.

7be2119

Reinstate log level.

a7d08c4

Reducing the diff between this and server.ts.

Be consistent with other custom events.

fc58dc7

Avoid negative look behind for Safari.

adf57b1

It's a syntax error so immediately scuppers things for Safari. This seems to be sufficient to get it running. Minimal testing so far but a big step forward. This specific change seems safe and well tested.

Merge branch 'main' into browser

74cd581

Interesting to see the import resolver hook and the nascent host abstraction.

Merge branch 'main' into browser-update

d061ab4

Merge pull request #7 from microbit-foundation/browser-update

be907c0

Update from upstream. Align URI parsing in browser-server.ts with corresponding changes to server.ts (we have several more occurrences in our added FS APIs).

Stub out process API we don't have. (#25)

4c6baa2

attempt to merge microbit-foundation's browser version of pyright

adf285e

DetachHead changed the title ~~Browser~~ Browser support Jul 22, 2024

This comment has been minimized.

Sign in to view

fix browser build

26a3f85

DetachHead force-pushed the browser branch from db1c9a4 to 88ed3ef Compare July 29, 2024 07:20

This comment has been minimized.

Sign in to view

DetachHead added 4 commits July 30, 2024 23:43

publish browser build to npm

decf2ac

suppress type error in test for now because im too lazy to figure it …

1a414f2

…out and it works at runtime

fix versions of dependencies in browser-pyright package that didn't m…

b1372d5

…atch the other packages

fix crashes when instantiating background threads

047da5d

DetachHead force-pushed the browser branch from d630dc2 to 047da5d Compare July 30, 2024 13:44

This comment has been minimized.

Sign in to view

DetachHead added 4 commits August 1, 2024 22:43

bundle typeshed with the browser build

7a8e32a

fix readme on browser package

3f03f13

delete useless override

9327da8

fix typeshed not being loaded

187c8be

DetachHead force-pushed the browser branch from d256bdc to 187c8be Compare August 4, 2024 06:33

DetachHead added 2 commits August 4, 2024 21:29

fix type error from new version of @types/nodejs

d2eef15

update browser docs

c67a4eb

DetachHead requested a review from KotlinIsland August 5, 2024 16:08

Merge remote-tracking branch 'refs/remotes/origin/main' into browser

0829419

# Conflicts: # packages/pyright-internal/src/analyzer/cacheManager.ts

DetachHead marked this pull request as ready for review August 5, 2024 16:13

This comment has been minimized.

Sign in to view

DetachHead added 2 commits August 6, 2024 21:16

delete unused test file

d50976b

fix typos in browser-basedpyright readme

4fd1e27

DetachHead merged commit 4fd1e27 into main Aug 6, 2024
19 checks passed

DetachHead deleted the browser branch August 6, 2024 12:21

DetachHead temporarily deployed to github-pages August 6, 2024 12:21 — with GitHub Actions Inactive

This was referenced Aug 11, 2024

primer results for sympy and spack are flaky #563

Open

"Error: Unhandled method workspace/configuration" when starting vscode extension #573

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Browser support #514

Browser support #514

DetachHead commented Jul 22, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 6, 2024

Browser support #514

Browser support #514

Conversation

DetachHead commented Jul 22, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 6, 2024

DetachHead commented Jul 22, 2024 •

edited

Loading