Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pre-commit to a separate repo to prevent it from attempting to build the package when the hook gets installed #440

Merged
merged 1 commit into from
Jun 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .pre-commit-hooks.yaml

This file was deleted.

13 changes: 3 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -399,20 +399,13 @@ integration with [pre-commit](https://pre-commit.com) is also supported.
# .pre-commit-config.yaml

repos:
- repo: https://github.com/DetachHead/basedpyright
rev: v1.8.0
- repo: https://github.com/DetachHead/basedpyright-pre-commit-mirror
rev: v1.13.0 # or whatever the latest version is at the time
hooks:
- id: basedpyright
```

to ensure that basedpyright is able to find all of the dependencies in your
virtual env, add the following to your `pyproject.toml`:

```toml
[tool.basedpyright]
# ...
venvPath = "."
```
for more information, see the documentation [here](https://github.com/DetachHead/basedpyright-pre-commit-mirror/blob/main/README.md)

# recommended setup

Expand Down
Loading