don't add @override decorator on method completions if targeting python <3.12 unless basedpyright.analysis.useTypingExtensions is enabled
#1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon <3.12 unless typing-extensions is installed
This comment has been minimized.
This comment has been minimized.
dcb5cb9 to
117acdf
Compare
@override decorator on method completions if targeting python <3.12 unless typing-extensions is installed@override decorator on method completions if targeting python <3.12 unless basedpyright.analysis.useTypingExtensions is enabled
… don't accidentally make their project depend on `typing_extensions`
117acdf to
1481187
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy)
- Type of "decompogen" is "(f: Unknown, symbol: Unknown) -> (list[Expr] | list[Function | Pow] | list[Expr | Basic] | list[Function | Pow | Basic] | Unknown | list[Min | Max | Basic] | list[Unknown | Max | Min | Basic] | list[Basic] | list[Min | Max] | list[Unknown | Max | Min] | list[Unknown])" (reportUnknownVariableType)
+ Type of "decompogen" is "(f: Unknown, symbol: Unknown) -> (list[Expr] | list[Function | Pow] | list[Expr | Basic] | list[Function | Pow | Basic] | Unknown | list[Min | Max | Basic] | list[Unknown | Max | Min | Basic] | list[Basic] | list[Unknown | Poly | Basic] | list[Min | Max] | list[Unknown | Max | Min] | list[Unknown] | list[Unknown | Poly])" (reportUnknownVariableType)
- Type of "factor" is "(f: Unknown, ..., deep: bool = False) -> (Unknown | Expr)" (reportUnknownVariableType)
+ Type of "factor" is "(f: Unknown, ..., deep: bool = False) -> (Unknown | Add | Expr | Mul)" (reportUnknownVariableType)
- Type of "eq" is "Unknown | None" (reportUnknownVariableType)
+ Type of "eq" is "Unknown | Expr | Any | Integer | None" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:128:19 - warning: Argument type is unknown
- Argument corresponds to parameter "expr" in function "_mexpand" (reportUnknownArgumentType)
- Type of "mainlog" is "Unknown | None" (reportUnknownVariableType)
+ Type of "mainlog" is "log | Any | Unknown | None" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:132:5 - warning: Type of "other" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:132:5 - warning: Type of "other" is partially unknown
+ Type of "other" is "Expr | Any | Unknown" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:132:13 - warning: Type of "subs" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:132:13 - warning: Type of "subs" is partially unknown
+ Type of "subs" is "Unknown | Overload[(arg1: Mapping[Basic | complex, Expr | complex], arg2: None = None) -> Expr, (arg1: Iterable[tuple[Basic | complex, Expr | complex]], arg2: None = None, **kwargs: Any) -> Expr, (arg1: Expr | complex, arg2: Expr | complex) -> Expr, (arg1: Mapping[Basic | complex, Basic | complex], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Iterable[tuple[Basic | complex, Basic | complex]], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Basic | complex, arg2: Basic | complex, **kwargs: Any) -> Basic] | Any" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:132:21 - warning: Argument type is partially unknown
+ Argument corresponds to parameter "arg1" in function "subs"
+ Argument type is "log | Any | Unknown" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:134:9 - warning: Type of "eq" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:134:9 - warning: Type of "eq" is partially unknown
+ Type of "eq" is "Expr | Any | Unknown" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:134:14 - warning: Type of "subs" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:134:14 - warning: Type of "subs" is partially unknown
+ Type of "subs" is "Overload[(arg1: Mapping[Basic | complex, Expr | complex], arg2: None = None) -> Expr, (arg1: Iterable[tuple[Basic | complex, Expr | complex]], arg2: None = None, **kwargs: Any) -> Expr, (arg1: Expr | complex, arg2: Expr | complex) -> Expr, (arg1: Mapping[Basic | complex, Basic | complex], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Iterable[tuple[Basic | complex, Basic | complex]], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Basic | complex, arg2: Basic | complex, **kwargs: Any) -> Basic] | Any | Unknown" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:134:32 - warning: Argument type is partially unknown
+ Argument corresponds to parameter "arg1" in function "subs"
+ Argument type is "log | Any | Unknown" (reportUnknownArgumentType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:134:41 - warning: Argument type is partially unknown
+ Argument corresponds to parameter "arg2" in function "subs"
+ Argument type is "Expr | Any | Unknown" (reportUnknownArgumentType)
- Type of "args" is "Unknown" (reportUnknownMemberType)
+ Type of "args" is "Tuple[Expr] | Any | Unknown" (reportUnknownMemberType)
- Type of "mainlog" is "Unknown" (reportUnknownVariableType)
+ Type of "mainlog" is "Expr | Any | Unknown" (reportUnknownVariableType)
- Type of "args" is "Unknown" (reportUnknownMemberType)
+ Type of "args" is "Tuple[Expr] | Any | Unknown" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:138:17 - error: Operator "-" not supported for type "Basic | Any | Unknown" (reportOperatorIssue)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:138:18 - warning: Type of "args" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:138:18 - warning: Type of "args" is partially unknown
+ Type of "args" is "tuple[Basic, ...] | Any | Unknown" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:139:9 - warning: Type of "eq" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:139:9 - warning: Type of "eq" is partially unknown
+ Type of "eq" is "Unknown" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:140:17 - warning: Type of "free_symbols" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:140:17 - warning: Type of "free_symbols" is partially unknown
+ Type of "free_symbols" is "Unknown | set[Basic] | Any" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:142:23 - warning: Argument type is unknown
- Argument corresponds to parameter "arg" in function "_linab" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:143:23 - warning: Argument type is unknown
- Argument corresponds to parameter "expr" in function "collect" (reportUnknownArgumentType)
- Type of "logarg" is "Expr | Unknown" (reportUnknownVariableType)
+ Type of "logarg" is "Expr | Any | Unknown" (reportUnknownVariableType)
- Type of "args" is "Tuple[Expr] | Unknown" (reportUnknownMemberType)
+ Type of "args" is "Tuple[Expr] | Any | Unknown" (reportUnknownMemberType)
- Type of "eq" is "Unknown | Expr | Any | Self@Expr" (reportUnknownVariableType)
+ Type of "eq" is "Unknown | Expr | Any" (reportUnknownVariableType)
- Type of "lhs" is "Unknown | Expr | Any | Self@Expr" (reportUnknownVariableType)
+ Type of "lhs" is "Unknown | Expr | Any" (reportUnknownVariableType)
- Type of "lhs" is "Unknown | Expr | Self@Expr | Any" (reportUnknownVariableType)
+ Type of "lhs" is "Unknown | Expr | Any" (reportUnknownVariableType)
- Type of "xreplace" is "Unknown | ((rule: Unknown) -> (Unknown | Expr)) | Any | ((rule: Unknown) -> (Unknown | Self@Expr))" (reportUnknownMemberType)
+ Type of "xreplace" is "Unknown | ((rule: Unknown) -> (Unknown | Expr)) | Any" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:460:9 - warning: Type of "f" is partially unknown
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:460:9 - warning: Type of "f" is unknown (reportUnknownVariableType)
- Type of "f" is "Unknown | Expr" (reportUnknownVariableType)
- Type of "as_expr" is "(*gens: Unknown) -> (Unknown | Expr)" (reportUnknownMemberType)
+ Type of "as_expr" is "(*gens: Unknown) -> Unknown" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:463:34 - warning: Type of "subs" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:463:34 - warning: Type of "subs" is partially unknown
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:463:34 - warning: Argument type is unknown
- Type of "subs" is "Unknown | Overload[(arg1: Mapping[Basic | complex, Expr | complex], arg2: None = None) -> Expr, (arg1: Iterable[tuple[Basic | complex, Expr | complex]], arg2: None = None, **kwargs: Any) -> Expr, (arg1: Expr | complex, arg2: Expr | complex) -> Expr, (arg1: Mapping[Basic | complex, Basic | complex], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Iterable[tuple[Basic | complex, Basic | complex]], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Basic | complex, arg2: Basic | complex, **kwargs: Any) -> Basic]" (reportUnknownMemberType)
+ Argument corresponds to parameter "rep" in function "__new__" (reportUnknownArgumentType)
- Type of "a" is "Unknown | None" (reportUnknownVariableType)
+ Type of "a" is "Unknown | Expr | Any | Self@Expr | Self@Add | None" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:477:9 - warning: Type of "free" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:477:9 - warning: Type of "free" is partially unknown
+ Type of "free" is "Unknown | set[Basic] | Any" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:477:16 - warning: Type of "free_symbols" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/bivariate.py:477:16 - warning: Type of "free_symbols" is partially unknown
- Type of "decompose" is "(f: Unknown, ...) -> (list[Unknown] | Unknown)" (reportUnknownVariableType)
... (truncated 4594 lines) ...
jinja (https://github.com/pallets/jinja)
pywin32 (https://github.com/mhammond/pywin32)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1097