Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook fixes #1046

Merged
merged 2 commits into from
Feb 8, 2025
Merged

notebook fixes #1046

merged 2 commits into from
Feb 8, 2025

Conversation

DetachHead
Copy link
Owner

No description provided.

This comment has been minimized.

@DetachHead DetachHead force-pushed the notebook-fixes branch 3 times, most recently from bb80dff to b1ba621 Compare February 8, 2025 10:02
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Diff from mypy_primer, showing the effect of this PR on open source code:

sympy (https://github.com/sympy/sympy)
-     Type of "factor" is "(f: Unknown, ..., deep: bool = False) -> (Unknown | Add | Expr | Mul)" (reportUnknownVariableType)
+     Type of "factor" is "(f: Unknown, ..., deep: bool = False) -> (Unknown | Expr)" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:51:13 - warning: Type of "eq" is partially unknown
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:51:13 - warning: Type of "eq" is unknown (reportUnknownVariableType)
-     Type of "eq" is "Unknown | Expr | Any" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:52:25 - warning: Argument type is unknown
+     Argument corresponds to parameter "expr" in function "collect" (reportUnknownArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:62:5 - warning: Return type, "dict[str, Unknown | Add | Expr | Mul | Any | Rational | NaN | ComplexInfinity | One | NegativeOne | Zero | Integer | Half | Float | Poly | str | list[Unknown]] | None", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:62:5 - warning: Return type, "dict[str, Unknown | Expr | Any | Rational | NaN | ComplexInfinity | One | NegativeOne | Zero | Integer | Half | Float | Poly | str | list[Unknown]] | None", is partially unknown (reportUnknownParameterType)
-     Type of "I1" is "Unknown | Add | Expr | Mul" (reportUnknownVariableType)
+     Type of "I1" is "Unknown | Expr" (reportUnknownVariableType)
-     Type of "J1" is "Unknown | Add | Expr | Mul" (reportUnknownVariableType)
+     Type of "J1" is "Unknown | Expr" (reportUnknownVariableType)
-     Type of "num" is "Expr | Mul | Unknown" (reportUnknownVariableType)
+     Type of "num" is "Expr | Unknown" (reportUnknownVariableType)
-     Type of "dem" is "Expr | Mul | Unknown" (reportUnknownVariableType)
+     Type of "dem" is "Expr | Unknown" (reportUnknownVariableType)
-     Type of "as_numer_denom" is "Unknown | (() -> tuple[Expr, Expr]) | (() -> tuple[Mul, Mul])" (reportUnknownMemberType)
+     Type of "as_numer_denom" is "Unknown | (() -> tuple[Expr, Expr])" (reportUnknownMemberType)
-     Argument type is "Unknown | Add | Expr | Mul" (reportUnknownArgumentType)
+     Argument type is "Unknown | Expr" (reportUnknownArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:98:36 - warning: Argument type is unknown
-     Argument corresponds to parameter "f" in function "factor" (reportUnknownArgumentType)
-     Type of "I0" is "Unknown | Add | Expr | Mul" (reportUnknownVariableType)
+     Type of "I0" is "Unknown | Expr" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:99:45 - warning: Argument type is unknown
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:99:45 - warning: Argument type is partially unknown
-     Argument corresponds to parameter "arg2" in function "subs" (reportUnknownArgumentType)
+     Argument corresponds to parameter "arg2" in function "subs"
+     Argument type is "Unknown" (reportUnknownArgumentType)
-     Type of "num" is "Expr | Mul | Unknown" (reportUnknownVariableType)
+     Type of "num" is "Expr | Unknown" (reportUnknownVariableType)
-     Type of "dem" is "Expr | Mul | Unknown" (reportUnknownVariableType)
+     Type of "dem" is "Expr | Unknown" (reportUnknownVariableType)
-     Type of "as_numer_denom" is "Unknown | (() -> tuple[Expr, Expr]) | (() -> tuple[Mul, Mul])" (reportUnknownMemberType)
+     Type of "as_numer_denom" is "Unknown | (() -> tuple[Expr, Expr])" (reportUnknownMemberType)
-     Type of "dem_args" is "tuple[Basic, ...] | tuple[Expr, ...] | Unknown" (reportUnknownVariableType)
+     Type of "dem_args" is "tuple[Basic, ...] | Unknown" (reportUnknownVariableType)
-     Type of "args" is "tuple[Basic, ...] | tuple[Expr, ...] | Unknown" (reportUnknownMemberType)
+     Type of "args" is "tuple[Basic, ...] | Unknown" (reportUnknownMemberType)
-     Type of "arg" is "Basic | Expr | Unknown" (reportUnknownVariableType)
+     Type of "arg" is "Basic | Unknown" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:123:32 - warning: Type of "as_base_exp" is partially unknown
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:123:32 - warning: Type of "as_base_exp" is unknown (reportUnknownMemberType)
-     Type of "as_base_exp" is "Unknown | (() -> tuple[Expr, Expr])" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:123:32 - warning: Argument type is unknown
+     Argument corresponds to parameter "object" in function "append" (reportUnknownArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:130:16 - warning: Return type, "dict[str, Unknown | Add | Expr | Mul | Any | Rational | NaN | ComplexInfinity | One | NegativeOne | Zero | Integer | Half | Float | Poly | str | list[Unknown]]", is partially unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:130:16 - warning: Return type, "dict[str, Unknown | Expr | Any | Rational | NaN | ComplexInfinity | One | NegativeOne | Zero | Integer | Half | Float | Poly | str | list[Unknown]]", is partially unknown (reportUnknownVariableType)
-     Type of "I" is "Unknown | Add | Expr | Mul" (reportUnknownVariableType)
+     Type of "I" is "Unknown | Expr" (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/hypergeometric.py:186:27 - warning: Argument type is unknown
+     Argument corresponds to parameter "expr" in function "collect" (reportUnknownArgumentType)
-     Type of "_s" is "Unknown | Add | Expr | Mul" (reportUnknownVariableType)
+     Type of "_s" is "Unknown | Expr" (reportUnknownVariableType)
-     Type of "factor" is "(f: Unknown, ..., deep: bool = False) -> (Unknown | Add | Expr | Mul)" (reportUnknownVariableType)
+     Type of "factor" is "(f: Unknown, ..., deep: bool = False) -> (Unknown | Expr)" (reportUnknownVariableType)
-     Type of "_B" is "Unknown | Add | Expr | Mul" (reportUnknownVariableType)
+     Type of "_B" is "Unknown | Expr" (reportUnknownVariableType)
-     Type of "_A" is "Unknown | Add | Expr | Mul" (reportUnknownVariableType)
+     Type of "_A" is "Unknown | Expr" (reportUnknownVariableType)
-     Type of "div" is "(f: Unknown, g: Unknown, ...) -> (tuple[Unknown, Unknown] | tuple[Unknown | Poly, Unknown | Poly])" (reportUnknownVariableType)
+     Type of "div" is "(f: Unknown, g: Unknown, ...) -> tuple[Unknown, Unknown]" (reportUnknownVariableType)
-     Type of "polyy" is "Unknown | dict[tuple[int, ...], Any] | dict[Unknown, Unknown]" (reportUnknownVariableType)
+     Type of "polyy" is "dict[tuple[int], Unknown] | dict[Unknown, Unknown] | dict[tuple[int, ...], Any]" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:537:33 - warning: Type of "values" is partially unknown
-     Type of "values" is "Unknown | (() -> dict_values[tuple[int, ...], Any]) | (() -> dict_values[Unknown, Unknown])" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:550:5 - warning: Return type, "list[dict[Expr, Basic | Unknown]] | None", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:550:5 - warning: Return type, "list[dict[Expr, Unknown]] | None", is partially unknown (reportUnknownParameterType)
-     Type of "cpoly" is "Unknown | dict[tuple[int, ...], Any] | dict[Unknown, Unknown]" (reportUnknownVariableType)
+     Type of "cpoly" is "dict[tuple[int], Unknown] | dict[Unknown, Unknown] | dict[tuple[int, ...], Any]" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:603:37 - warning: Type of "values" is partially unknown
-     Type of "values" is "Unknown | (() -> dict_values[tuple[int, ...], Any]) | (() -> dict_values[Unknown, Unknown])" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:617:25 - warning: Type of "xic" is partially unknown
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:617:25 - warning: Type of "xic" is unknown (reportUnknownVariableType)
-     Type of "xic" is "Unknown | Poly" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:617:30 - warning: Type of "etac" is partially unknown
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:617:30 - warning: Type of "etac" is unknown (reportUnknownVariableType)
-     Type of "etac" is "Unknown | Poly" (reportUnknownVariableType)
-     Type of "inf" is "dict[Expr, Basic | Unknown]" (reportUnknownVariableType)
+     Type of "inf" is "dict[Expr, Unknown]" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:618:37 - warning: Type of "subs" is partially unknown
+   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:618:37 - warning: Type of "subs" is unknown (reportUnknownMemberType)
-     Type of "subs" is "Unknown | Overload[(arg1: Mapping[Basic | complex, Basic | complex], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Iterable[tuple[Basic | complex, Basic | complex]], arg2: None = None, **kwargs: Any) -> Basic, (arg1: Basic | complex, arg2: Basic | complex, **kwargs: Any) -> Basic]" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:618:47 - warning: Argument type is unknown
-     Argument corresponds to parameter "arg1" in function "subs" (reportUnknownArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/lie_group.py:618:50 - warning: Argument type is unknown
-     Argument corresponds to parameter "arg2" in function "subs" (reportUnknownArgumentType)

... (truncated 4135 lines) ...

@DetachHead DetachHead merged commit 88749f0 into main Feb 8, 2025
20 checks passed
@DetachHead DetachHead deleted the notebook-fixes branch February 8, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant