-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document how to install the cli more clearly #178
Comments
@baco would you mind taking a look at this? |
@leet0rz it seems you need to update Try upgrading the plugin with the package manager you are using on your Neovim. |
I am just using regular lspconfig as instructed from the repo with Neovim.
I do have it installed as instructed through the marketplace of vscode. Guess my initial thought was on point from it missing in PATH? What file exactly does it call, what has to be in PATH for the terminal to be able to call this? |
Excellent, I supposed that was the case (that you didn't have
says it so:
meaning “the plugin didn't know of any The new error you are getting also says it so:
Now, How do you install your LSP servers? Are you using If you are using both, take into account that both of those plugins need to be up to date as well. If you are using neither, you can still install Tell us how it went!! |
It seems to be working after doing |
I think so. The visualstudio marketplace is for VSCode extensions. I mean, if you knew already you were needing the LSP server for Neovim only, why bothering installing extensions for an editor you don't use? But I don't think the documentation is misleading in that sense. There are separate sub-sections for each editor, and certainly the Neovim sub-section doesn't says anything about the visualstudio marketplace. |
I guess I did not see the section split there but in my defense I just checked your basedpyright front page, your installation page and lspconfig's basedpyright page. None of them have anything resembling Looking at these 3 links: |
First of all, I wouldn't like to seal any project credits whatsoever. The project is not mine, I am just helping with the documentation regarding Neovim configuration (that's why DetachHead asked for my help here). Having clarified that, the documentation does tell how to install the Command Line Interface standalone. Just the next section after all the editors configuration alternatives. Whether it is among your specific needs to have it installed that way or not, is solely dependent on the setup of your Neovim, which this project doesn't intent to cover. For instance, I don't need to install it that way, I use Mason, as many people does. And the documentation doesn't cover that installation method, because is one way to setup Neovim, not the LSP itself but Neovim as an editor. And as it is my preference to use an alternative setup for my Neovim, I should know how to deal with that if it wasn't working, perhaps go to ask to that project instead. What I mean at this point is, that I think your first inquiry is valid, because perhaps you didn't know when |
Considering this is a python language server, there is nothing up front on the front page of the repo or under the installation guide that tells us how to install it. The neovim part tells us how to set it up under lspconfig as with everything else and that is simple like with any other language server, but that is "usage", not "installation" . If its hidden behind the command-line section that's something entirely different, which will cause confusion. Most of the time the global way to install the language server is right up front in the repo under "installation > pip install blabla", not hidden under layers of abstraction. Most of the people who use neovim and actually program it ourselves see mason as just bloatware, it's usually better to go to the repo, install the language server yourself and put the language server in PATH so it's callable for neovim, there is no reason to use mason for this, it's just another plugin that can break and provide errors like we've seen with so many of our users in our neovim discord. We usually recommend staying away from mason for that exact reason. Anyway, thanks for letting me know it was just a simple pip package. Last question, does it not support pyside6 yet? It does not seem to recognize when I import pyside6 functionality. No issues while using regular pyright or jedi. Thanks. |
Yeahp... there is no solution about the unwillingness to read the whole documentation 😕. But you could improve on that by offering a PR instead, highlighting the parts you consider are most important. I'm sure @DetachHead will appreciate that other approach better.
I don't know, not a Qt fan myself. Perhaps @DetachHead has more insight about that. |
the reason i didn't put
if you’re running into issues importing things it may be the same issue as #158. i haven’t been able to reproduce any issues importing 3rd party packages though, so if you could produce a minimal example that would be appreciated |
i added one of these thingies to the installation instructions: hope this makes it more clear |
I would put that at the top or similar to tmux's repo right at the front page and not near the bottom. But that's just me, you do you. I'll get back to checking in more on the pyqt/pyside issue a bit later. |
Probably part of the confusion is generated by the fact that the terminology "installation instruction" points to local lspconfig = require("lspconfig")
lspconfig.basedpyright.setup{} and that should be re-named as "neovim configuration instructions" or the like, the installation pointing to a generic way to install a python program as per here. For people who are unfamiliar to language servers (and come from IDE packaged solutions) it's unclear that a language server is a program that must be installed on your computer first and only then configured in your editor - which is why pointing the installation instructions to neovim configuration might generate confusion for some. |
@gennaro-tedesco please feel free to file another issue if you think an improvement could be made here. |
@gennaro-tedesco thanks for pointing this out, i noticed the pycharm extension also requires the pypi package to be installed so i updated the docs in #366 |
After following the guide on installing from the market place and setting it up under lspconfig with
lspconfig.basedpyright.setup{}
I get this message when opening a py file:Usually when I get errors with other language servers its because its not in PATH and callable via terminal, but I am not sure what part of this needs to be in PATH for it to work, maybe you can help me with that.
The text was updated successfully, but these errors were encountered: