fix reportUnusedParameter on parameters prefixed with _

DetachHead · Aug 17, 2024 · b71e998 · b71e998
1 parent b92ac27
commit b71e998
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/pyright-internal/src/analyzer/checker.ts b/packages/pyright-internal/src/analyzer/checker.ts
@@ -3661,12 +3661,6 @@ export class Checker extends ParseTreeWalker {
 
                 if (decl.node.nodeType === ParseNodeType.Name) {
                     nameNode = decl.node;
-
-                    // Don't emit a diagnostic if the name starts with an underscore.
-                    // This indicates that the variable is unused.
-                    if (!nameNode.d.value.startsWith('_')) {
-                        rule = DiagnosticRule.reportUnusedVariable;
-                    }
                 } else if (decl.node.nodeType === ParseNodeType.Parameter) {
                     nameNode = decl.node.d.name;
 
@@ -3693,12 +3687,16 @@ export class Checker extends ParseTreeWalker {
                     rule = DiagnosticRule.reportUnusedVariable;
                 }
 
-                if (nameNode) {
+                // Don't emit a diagnostic if the name starts with an underscore.
+                // This indicates that the variable is unused.
+                if (nameNode && !nameNode.d.value.startsWith('_')) {
                     message = (
                         rule === DiagnosticRule.reportUnusedParameter
                             ? LocMessage.unaccessedSymbol()
                             : LocMessage.unaccessedVariable()
                     ).format({ name: nameNode.d.value });
+                } else {
+                    rule = undefined;
                 }
                 break;
 

diff --git a/packages/pyright-internal/src/tests/samples/reportUnusedParameter.py b/packages/pyright-internal/src/tests/samples/reportUnusedParameter.py
@@ -15,4 +15,6 @@ class Bar(Foo):
     def foo(self, asdf: int): ...
 
     @override
-    def bar(self, asdf: int): ...
+    def bar(self, asdf: int): ...
+
+def bar(_value: int): ...