Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chrono steady_clock for time measurement #394

Merged
merged 2 commits into from
May 28, 2024
Merged

Use chrono steady_clock for time measurement #394

merged 2 commits into from
May 28, 2024

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Implementing static ChronoTimer class based on C++11 chrono library that replaces platform dependent time measurement implementation.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@winterheart
Use chrono steady_clock for time measurement
24e0c31 
Implementing static ChronoTimer class based on C++11 chrono library that replaces platform dependent time measurement implementation.
@winterheart
Remove unused lorestimer arg option
683cac5 
lorestimer was required only for Windows (9x, I guess?), and now with chrono library, that can provide any resolution, it's redundant. Removing related field of ddio_init_info struct.
@winterheart winterheart force-pushed the ddio-update-crossplatform branch from 0d0a5cb to 683cac5 Compare May 27, 2024 07:32
@Lgt2x Lgt2x self-assigned this May 27, 2024
Lgt2x
Lgt2x approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, tested working on Linux.

@Lgt2x Lgt2x merged commit e74ba03 into DescentDevelopers:main May 28, 2024
12 checks passed
@winterheart winterheart deleted the ddio-update-crossplatform branch August 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lgt2x Lgt2x Lgt2x approved these changes

Assignees

@Lgt2x Lgt2x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winterheart @Lgt2x