Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt #220

Merged
merged 5 commits into from
Apr 28, 2024
Merged

Update CMakeLists.txt #220

merged 5 commits into from
Apr 28, 2024

Conversation

winterheart
Copy link
Collaborator

@winterheart winterheart commented Apr 28, 2024 •
edited
Loading

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

This PR incorporate scivision changes from #146 with additional fixes and minor enhancements.

Related Issues

Closes #146.

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

scivision and others added 5 commits April 28, 2024 14:04
@scivision @winterheart
cmake: modernize, using safer/clearer options
1188b65 
CMAKE_BUILD_TYPE must be set CACHE before project() to take effect

general best practice rather than modifying CMake internal variables
is to use add_compile_options with genex
@scivision @winterheart
cmake: use find_* name-value for readability
31855c8
@scivision @winterheart
cmake: use CMAKE_SYSTEM_NAME where prudent
4d109a1
@scivision @winterheart
cmake: use regex to simplify
1f9c8cb 
ref compiler ids:
https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html
@winterheart
Fix typo in CMakeLists.txt
bdcb6cd 
Change CMAKE_SYTEM_NAME with CMAKE_SYSTEM_NAME, replace add_definitions with add_compile_definitions.
@JeodC JeodC merged commit dbe2cde into DescentDevelopers:main Apr 28, 2024
5 checks passed
JeodC added a commit that referenced this pull request Apr 28, 2024
@JeodC
Merge pull request #220 from winterheart/main-cmake
8df30f9 
Update CMakeLists.txt
@winterheart winterheart deleted the main-cmake branch May 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winterheart @JeodC @scivision