Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntfy access token #434

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Ntfy access token #434

merged 7 commits into from
Jan 12, 2024

Conversation

web2brain
Copy link
Contributor

@web2brain web2brain commented Jan 4, 2024

Pull Request Checklist

  • Have you checked to ensure there aren't other open
    Pull Requests for the same update/change?
  • Did you make your Pull Request on the dev branch?
  • Does your submission pass tests? make test
  • Have you lint your code locally prior to submission? make lint
  • Could you build and run the docker image successfully? make image
  • Could you create a running executable? make executable
  • Have you added an explanation of what your changes do
    and why you'd like to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran manual tests with your changes locally?

Adds the possibility to access token instead of username and password for Ntfy.
I won’t have the possibility to test this until next week, but nevertheless wanted to create the pull request already.

@Der-Henning
Copy link
Owner

Hi @web2brain.
Thank you for your PR.
Please switch the PR to the dev branch and ensure tests and pre-commit succeed.
I will have a look at your code as soon as you say that you are done :)
You could also set the PR status to draft to indicate that it's still a work in progress.

@web2brain web2brain changed the base branch from main to dev January 4, 2024 22:28
@web2brain web2brain closed this Jan 4, 2024
@web2brain web2brain reopened this Jan 4, 2024
@web2brain web2brain marked this pull request as draft January 4, 2024 22:33
@web2brain web2brain marked this pull request as ready for review January 12, 2024 15:43
@web2brain
Copy link
Contributor Author

Hi @Der-Henning,
I built the docker images (and the other things from the check list) locally and tested tgtg-scanner:latest-alpine with an access token for ntfy and it worked. If there is something else I should do, please let me know. I hope you'll include the pull request as I'd like to use tokens for ntfy instead of username and password.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (86ccb0d) 64.71% compared to head (e3b685a) 64.80%.
Report is 10 commits behind head on dev.

Files Patch % Lines
tgtg_scanner/models/metrics.py 33.33% 6 Missing ⚠️
tgtg_scanner/notifiers/ntfy.py 66.66% 2 Missing ⚠️
tgtg_scanner/scanner.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #434      +/-   ##
==========================================
+ Coverage   64.71%   64.80%   +0.08%     
==========================================
  Files          26       26              
  Lines        2202     2216      +14     
==========================================
+ Hits         1425     1436      +11     
- Misses        777      780       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Der-Henning
Copy link
Owner

Thank you @web2brain. Nice work.
I actually didn't know the |= operator. :)
I will merge the main ASAP so this will be available on edge builds.
The next release will take a week or two.

@Der-Henning Der-Henning merged commit 8d76369 into Der-Henning:dev Jan 12, 2024
18 of 21 checks passed
@web2brain web2brain deleted the ntfyAccessToken branch January 12, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants