Pull config via @ConfigProperty in notification-publisher
#1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f1cfab to
5cf837e
Compare
@ConfigProperty in notification-publisher
75dcf81 to
60599ec
Compare
2 tasks
This replaces manual usage of `ConfigPropertyRepository` with more Quarkus-idiomatic `@ConfigProperty` injection. It leverages the new `quarkus-config-dependencytrack` extension. Another unforeseen benefit is that it's now possible to simply provide property overrides for tests, instead of having to persist anything in a database. Relates to #929 Signed-off-by: nscuro <nscuro@protonmail.com>
Requires different properties, which can only be set on class level with test profiles. Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Turns out `@Test` annotations have no effect when set on methods in an `abstract` class. junit-team/junit5#960 Signed-off-by: nscuro <nscuro@protonmail.com>
They are no longer needed, as the `CONFIGPROPERTY` table is now consumed via `@ConfigProperty` annotations. Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Note that the `quarkus-mailer` dependency is still required in order to be able to use Vert.x's `MailClient`. Fixes #1232 Signed-off-by: nscuro <nscuro@protonmail.com>
1178cb1 to
e8ed09f
Compare
|
VithikaS
approved these changes
May 6, 2024
nscuro
added a commit
that referenced
this pull request
May 20, 2024
Email configuration is pulled from the database as of #1229. The e2e test still assumed configuration via properties. Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
added a commit
that referenced
this pull request
May 20, 2024
Email configuration is pulled from the database as of #1229. The e2e test still assumed configuration via properties. Signed-off-by: nscuro <nscuro@protonmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
This PR is based on #1223. Please review that first, I'll update this PR once it is merged. Should drastically reduce the change size. :)This replaces manual usage of
ConfigPropertyRepositorywith more Quarkus-idiomatic@ConfigPropertyinjection. It leverages the newquarkus-config-dependencytrackextension.Another unforeseen benefit is that it's now possible to simply provide property overrides for tests, instead of having to persist anything in a database.
Addressed Issue
Relates to #929
Fixes #1232
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly