Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Save Sidebar state in local storage #988

Conversation

Gepardgame
Copy link
Contributor

Description

Used LocalStorage to store the expanded
state of the sidebar, so it persists over sessions

Addressed Issue

Fixes #864

Additional Details

Loads state out of LocalStorage and applies it. Then Sidebar is toggled, it gets saved in localStorage over an additional click event handler method.

Checklist

@Gepardgame Gepardgame force-pushed the feat/Navigation-sidebar-state-not-retained-between-sessions branch 3 times, most recently from f76c31f to c7d1812 Compare September 10, 2024 07:13
@nscuro nscuro added the enhancement New feature or request label Sep 10, 2024
@nscuro
Copy link
Member

nscuro commented Sep 10, 2024

Same as #986 (comment), please make sure you're not modifying other commits.

@Gepardgame Gepardgame closed this Sep 11, 2024
@Gepardgame Gepardgame force-pushed the feat/Navigation-sidebar-state-not-retained-between-sessions branch from 61af2c1 to 97bd19c Compare September 11, 2024 05:54
…panded state of the sidebar, so it persists over sessions

Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
@Gepardgame Gepardgame reopened this Sep 11, 2024
@nscuro nscuro added this to the 4.12 milestone Sep 11, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit 1e5f3b9 into DependencyTrack:master Sep 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation sidebar state not retained between sessions
2 participants