Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes to fix prettier behavior on Windows #1042

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Oct 9, 2024

Description

Adds .gitattributes to fix prettier behavior on Windows.

Since prettier enforces LF line endings, it would forcefully convert Windows' CLRF linebreaks on every run, causing undesired changes for contributors using Windows.

This is taken from prettier's own .gitattributes file: https://github.com/prettier/prettier/blob/main/.gitattributes

Addressed Issue

N/A

Additional Details

N/A

Checklist

@nscuro nscuro added the dx Issues related to developer experience (DX) label Oct 9, 2024
@nscuro nscuro added this to the 4.13 milestone Oct 9, 2024
Since prettier enforces LF line endings, it would forcefully convert Windows' CLRF linebreaks on every run, causing undesired changes for contributors using Windows.

This is taken from prettier's own `.gitattributes` file: https://github.com/prettier/prettier/blob/main/.gitattributes

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro merged commit 1ddeb0b into DependencyTrack:master Oct 9, 2024
10 checks passed
@nscuro nscuro deleted the gitattributes branch October 9, 2024 12:55
@nscuro nscuro added the backport/4.12.1 PRs to be backported to version 4.12.1 label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.12.1 PRs to be backported to version 4.12.1 dx Issues related to developer experience (DX)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant