Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no unique constraint violation for ProjectMetadata #3982

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jul 15, 2024

Description

Adds regression test for #3895. The behavior itself does not reproduce on master, but does with 4.11.5.

Wraps the project cloning in a transaction to make it more reliable. Adds MDC variables for CloneProjectTask (#3234).

Addressed Issue

Fixes #3895
Relates to #3981

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Adds regression test for DependencyTrack#3895. The behavior itself does not reproduce on `master`, but does with `4.11.5`.

Wraps the project cloning in a transaction to make it more reliable. Adds MDC variables for `CloneProjectTask` (DependencyTrack#3234).

Fixes DependencyTrack#3895

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the defect Something isn't working label Jul 15, 2024
@nscuro nscuro added this to the 4.12 milestone Jul 15, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 91.13% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (84eca3c) 22097 16869 76.34%
Head commit (164847a) 22108 (+11) 16887 (+18) 76.38% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3982) 124 113 91.13%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 4420a9d into DependencyTrack:master Jul 15, 2024
11 checks passed
@nscuro nscuro deleted the issue-3981 branch July 15, 2024 19:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOM upload after clone of project might get stuck/fail
1 participant