Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(external-references): add component evidence entries for file/path #3591

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Mar 30, 2024

Description

When processing BOM uploads, set evidenceexternal references for components based on

  • component properties with name SrcFile - cdxgen populates this currently
  • component evidence occurences

Addressed Issue

Can be hard currently to pinpoint the origin of a component, especially within large codebases

Additional Details

Attached is an example of how this data flows through
Screenshot 2024-03-30 at 7 57 48 AM

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: Adam Setch <adam.setch@outlook.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 25.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c15560b) 21606 16001 74.06%
Head commit (7ba9afc) 21618 (+12) 16004 (+3) 74.03% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3591) 16 4 25.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@setchy
Copy link
Contributor Author

setchy commented Mar 30, 2024

I'll happily add additional test cases once I get the 👍 from maintaines on the direction of this enhancement

@setchy
Copy link
Contributor Author

setchy commented Apr 1, 2024

Looks like #3499 may help out here...

@setchy
Copy link
Contributor Author

setchy commented Apr 15, 2024

Closing now that #3499 landed

@setchy setchy closed this Apr 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant