Deleting a child election does not update the parent's modified timestamp

[awdem]

Peter deleted a ballot-level election that was made mistakenly. This updated the modified timestamp for the ballot-level election, but didn't update its parent election's modified timestamp.

Aside from this causing some issues with other project's EE importers, it would make sense that deleting a child election also updates the parent election's modified timestamp because the parent has one less child.

For more info on the soft delete system: https://github.com/DemocracyClub/EveryElection/wiki/Cancelled-Elections-and-Soft-Deletes

One potential fix:

In the ModerationHistory.save() method, touch the modified date of any parent elections as well as the election object itself:

EveryElection/every_election/apps/elections/models.py

Lines 556 to 569 in 0decd2d

	def save(self, **kwargs):
	# if this is the initial status no need to update the related election
	# so return early. This is because the default status is identical on
	# both this model and the Election model
	if kwargs.pop("initial_status", False):
	return super().save(**kwargs)
	# save the related election to update the modified timestamp so that it
	# is found by the importer looking for recent changes
	if self.election.current_status != self.status.short_label:
	self.election.current_status = self.status.short_label
	self.election.save()
	super().save(**kwargs)
	return None

related issue on YNR: #2289

[awdem]

Adjacent issue:

two ballot-level elections were created and approved after their parent election local.2024-12-05. Their creation and approval didn't update the parent election modified timestamp. These ballot-level elections weren't synced by YNR because it only syncs recently modified parent elections. I think that this a change like the one suggested above would also address this issue, but it worth investigating.