Frontier Mail #1652

ghost · 2024-08-18T07:18:25Z

About the PR

Fixes #1031, sort of.
Ports changes made to mail that have been made by Frontier, that clean up the code of the mail system nicely by tweaking C#. Needs to be tested a bit more, but seems to run smoothly for the most part.
What this PR does:

Adds the Mail RPDS, and gives the courierdrobe two of it. Couriers now have access to the mail gun
Adds a shit ton of Frontier Mail, overhauls existing Nyano Mail, localizes mail.yml, all of the files for department mail yaml and mailDeliveries.yml to DeltaV folders. Obliterates a bunch of nyano files as a result, and rebalances the mail table.
creates frontierMigrations.yml because Velcro mapped a mail prototype (WHY?!)

Some things that need to be done later, out of the scope of this PR maybe:

Localization of mail papers
Just make more mail tbh. I need people to be sent more fucked up things. If you have any ideas for mail that can provoke RP i'm open

Why / Balance

Mail is old, and Frontier made some nice changes to mail, and I want the courier to be able to shoot people with the mail china lake.
Furthermore, mail can be used to combat people meta-ing certain items like syndie clothes if you put those in the mail.

Technical details

Changes MailSystem C#, creates an entirely new mail table that shares a load of stuff with Frontier, creates frontierMigrations. Mostly C#, YAML, and I guess map changes because frontierMigrations.

Media

Requirements

I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 Whatstone, dvir001, ErhardSteinhauer, Adeinitas

tweak: New ads are in the mail and various mail has been expanded upon.
add: You may find larger parcels in the mail.
add: The mail RPDS is now in the courierdrobe - shoot your friends (and enemies) with the mail gun today!!!

…start thinking about MailSystem

* Mail RPDS * removed sizes, more items go in capsules * fixed error * capsule resprite, added it to service techfab * Update after upstream merge * glass * Update frontier.yml * tag fix --------- Co-authored-by: Dvir <dvirf01@gmail.com>

* MailUp * Update base_mail.yml * Update base_mail.yml * Update MailTeleporterComponent.cs * Update MailComponent.cs * Update base_mail.yml * Update base_mail.yml * Update Resources/Prototypes/Nyanotrasen/Entities/Objects/Specific/Mail/base_mail.yml Sure Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> --------- Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>

github-actions · 2024-08-18T07:19:06Z

RSI Diff Bot; head commit 813e771 merging into 28859af
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Misc/mail_capsule.rsi

State	Old	New	Status
icon-cash			Added
icon-empty			Added
icon-food			Added
icon-mail			Added
spent			Added

Resources/Textures/_NF/Objects/Specific/Mail/mail_large.rsi

State	Old	New	Status
broken			Added
fragile			Added
icon			Added
inhand-left			Added
inhand-right			Added
locked			Added
priority			Added
priority_inactive			Added
trash			Added

Resources/Textures/_NF/Objects/Weapons/Guns/Launchers/mail.rsi

State	Old	New	Status
bolt-open			Added
equipped-BACKPACK			Added
equipped-BELT			Added
icon			Added
inhand-left			Added
inhand-right			Added

Edit: diff updated after 813e771

dvir001 · 2024-08-18T16:39:53Z

You probably missing some of the mail related PR's from our side.
Also we just had another PR to fix some issues with the mail app code and port it.

ghost · 2024-08-18T22:32:50Z

You probably missing some of the mail related PR's from our side. Also we just had another PR to fix some issues with the mail app code and port it.

I'm draft PRing this because I intend on working on it again. It's 2 months old. I gave up on it because the frontier mail table PR closed and I was having trouble cherrypicking specific shit from that.
I am missing the one that made a number of fixes to mail because it was part of the mail table ( that's frontier-station-14's #1477 ) and then I need to track down the rest of the mail fixes, nuke the frontier-specific calculations that account for addressing to the multiple ships (since this is only one station, i think), and then create the DV mail table.

* Mail table, system for smoke prank * Format mail messages * DelayedItemSystem cleanup, more mail table entries * More mail table entries * Remove hoverbike from mail pool * Add large mail. FIXME: mail_large.rsi has no copyright info * Default mail isLarge to false, comment cleanup * More mail types * Add optional large mail flag to admin mailto cmd * mail_large copyright * admin cmd fix, new mail types, const cleanup * Mail: new components, weighting, a few new items * Fix merge conflict, add placeholder pipebomb mail * Format mail text, separate sword mail from knives * Mail: fix exp. welder ID, split up Dan's cigs * Fourth muffin, decrease captain's sabre chance * yaml fixes * Add ShowJobIcons component to mail hud * Reorganize mail items, add build-a-buddy mail * Build-a-Buddy fixes, slime & vulp versions, text * Reptillian->Reptilian * More signatures, label necrosol bottle, bigger emp * lowercase i * extra premium cigars, premium liquors * Cleanup * Fixups And Edits * Remove kendo hakama, jabroni comment, fix cigars * Platinum cigars, fix sprites * fix premium absinthe ID * Remove cyberpen, add BibleUserImplanter, ATV mail Also adjusts weights for TacticalMaid (missing a zero), Restraints (cut in half) * kendo mail order, more mail comments * Remove Nyano mail lists & parcels, move into _NF/ * True to true, cigars aren't fragile --------- Co-authored-by: Dvir <dvirf01@gmail.com> Co-authored-by: Whatstone <whatstone3@gmail.com>

…to 5 ymls again

FUCK YOU BUILD ERROR !!! EAT SHIT

Adei versus the one silly

💀

… to how it was

ghost · 2024-08-22T07:05:28Z

Okay, I think this is complete enough to be opened and reviewed, but not merged whatsoever. The one thing it seems to be continuing to throw up whenever I open my devenv and test things is the platinum cigar's RSI, even though I exploded the cigar and it's gone. Look in at your own peril - I definitely need more eyes on this because there's just so many mistakes and there may or may not be things I either forgot to add from the frontier mail PR or things that break when opened.

Since there's no intent for it to spawn in the mail, might as well.

into The-Mail-Refactor

ghost · 2024-08-22T07:24:06Z

Wow, the linter has came for me, and it's throwing fucking hard punches. Jesus christ.

Resources/Locale/en-US/Mail/mail.ftl

Content.Server/Nyanotrasen/Mail/Components/MailTeleporterComponent.cs

Content.Server/Nyanotrasen/Mail/MailCommands.cs

Resources/Locale/en-US/Mail/mail.ftl

Resources/Prototypes/Nyanotrasen/Catalog/Fills/Vending/Inventories/maildrobe.yml

Does some shit to the mail / courierdrobe and gets rid of string keys. Thanks Milon

MilonPL

Haven't looked at the yaml mail tables but I trust these are fine.

Resources/Locale/en-US/nyanotrasen/Mail/mail.ftl

Resources/Prototypes/Nyanotrasen/Catalog/Fills/Vending/Inventories/maildrobe.yml

into The-Mail-Refactor

…t effect sprites

This reverts commit 0ee3869.

This reverts commit 29129df.

ghost · 2024-08-23T09:13:20Z

All checks have passed, and with that, I think I'm finally done. Sorry for the commit spam, now an actual maint can review this and merge.

ANOTHER COMMIT FOR THE PILE.

MilonPL

nospawn: true is obsolete and will be completely removed soon, should be replaced with categories: [ HideSpawnMenu ], which isn't needed because it's inhereted from BaseMail.

ghost · 2024-08-25T23:25:05Z

nospawn: true is obsolete and will be completely removed soon, should be replaced with categories: [ HideSpawnMenu ], which isn't needed because it's inhereted from BaseMail.

FUCK

ghost · 2024-08-26T00:45:03Z

Okay, now this is Really Actually the end of me commit spamming this, trust.

ghost · 2024-08-27T07:22:54Z

Don't need Velcro's insight because it's not a direct map change, anymore. Velcro, you're still free to look though, but the adding you to the PR was accidental
I'd like insight from the carp man and the other yamltainer to see what they think of this!
I'd also like insight from the Game Directors, once they are able to review.

therealDLondon

I'm Fox, and this is my favourite PR on the Repo.

Tests pass, Milon nods, the fish man weeps silently somewhere

# Description Showing some love to our hard-working couriers. This cherry-picks the following PRs from delta-v: - DeltaV-Station/Delta-v#1472 - Adds a MailMetrics PDA cartridge for couriers and the LO - DeltaV-Station/Delta-v#1652 - Ports mail tweaks from frontier to delta-v, adding large packages, RPDs (mail cannons), and more mail - DeltaV-Station/Delta-v#1788 - Adding a couple more packages - DeltaV-Station/Delta-v#1925 - Fixing the non-functional "last known location" part of mail descriptions Some mail items, such as the opporozidone syringe and rainbow joints/blunts, had to be disabled because we don't have them (yet?) <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/user-attachments/assets/2299ffc3-17ce-4743-886c-7705e8789e96) ![image](https://github.com/user-attachments/assets/a2ee1a07-d765-41e7-8f70-f94a50412398) ![image](https://github.com/user-attachments/assets/03b16b8e-0eff-4332-99ad-d4a201ee8f2b) ![image](https://github.com/user-attachments/assets/44d2e5c2-db79-4d8d-8877-693648edd35d) ![image](https://github.com/user-attachments/assets/f3d7bdbb-fc14-4f2f-bf30-aa54fdf49099) ![image](https://github.com/user-attachments/assets/b1e4c53f-c9d8-496b-a72e-f4f4b702e368) </p> </details> --- # Changelog :cl: - add: The Courier and Logistics Officer now have a new program in their PDA for tracking mail delivery performance, including earnings and percent of packages opened, damaged, or expired. - add: The list of possible mail packages has been greately expanded, and now includes large parcels. - add: The CourierDrobe now offers a rapid mail delivery device, along with capsules for it. --------- Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com> Co-authored-by: portfiend <109661617+portfiend@users.noreply.github.com> Co-authored-by: byte <50130120+huckleton@users.noreply.github.com> Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com> Co-authored-by: Adeinitas <147965189+adeinitas@users.noreply.github.com> Co-authored-by: ErhardSteinhauer <65374927+ErhardSteinhauer@users.noreply.github.com> Co-authored-by: Dvir <dvirf01@gmail.com> Co-authored-by: Dvir <39403717+dvir001@users.noreply.github.com> Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> Co-authored-by: Whatstone <whatstone3@gmail.com> Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Co-authored-by: Milon <plmilonpl@gmail.com>

more than likely this is just because of invalid loadouts

adeinitas and others added 3 commits June 28, 2024 16:39

Does all the under the hood changes to mail components before I EVEN …

458a0fa

…start thinking about MailSystem

github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Aug 18, 2024

Merge branch 'master' into The-Mail-Refactor

bc31ced

whatston3 and others added 10 commits August 19, 2024 05:24

Kills accidentally cherrypicked platinum cig, makes mail be sorted in…

22e4fb4

…to 5 ymls again

THE MAIL TABLE!!!!! AHHHHHHHHHHHHHHHHHHHH

8e1db27

NUKES two UNNECCESSARY RANDOMLY PASTED BRACKETS

81d4308

FUCK YOU BUILD ERROR !!! EAT SHIT

a semicolon for good measure

af07919

Adei versus the one silly

Fuck is this? Why is it in my mail?

1ba12cf

Pro forgot values for two of the engineering mails

4cd9972

💀

First pass to fix various mail bugs + editing of papers

60da64b

obliterates a random S in a C# file, also returns the mail teleporter…

ef5c174

… to how it was

Merge branch 'master' into The-Mail-Refactor

ed10f45

ghost marked this pull request as ready for review August 22, 2024 07:05

adeinitas added 2 commits August 22, 2024 04:12

Nukes the platinum cigar's YAML

be4c1ba

Since there's no intent for it to spawn in the mail, might as well.

Merge branch 'The-Mail-Refactor' of https://github.com/adeinitas/Delta-v

15d616d

into The-Mail-Refactor

MilonPL suggested changes Aug 22, 2024

View reviewed changes

Milon's Review

ebafc0a

Does some shit to the mail / courierdrobe and gets rid of string keys. Thanks Milon

MilonPL suggested changes Aug 22, 2024

View reviewed changes

Milon's Review 2, Electric Boogaloo

33568e5

adeinitas added 8 commits August 23, 2024 04:57

Merge branch 'The-Mail-Refactor' of https://github.com/adeinitas/Delta-v

2475617

into The-Mail-Refactor

Just gives the delayed smoke prank and delayed EMP effects the instan…

8dbea7a

…t effect sprites

Where the fuck are these random curly braces from??

a337b6c

An attempt to satisfy the Yaml Linter

4c50a3e

Revert "Update Resources/Locale/en-US/nyanotrasen/Mail/mail.ftl"

021c446

This reverts commit 0ee3869.

Revert "Update Resources/Locale/en-US/_NF/mail/mail.ftl"

1243ec0

This reverts commit 29129df.

Mail FTL fixes / I think I know what the linter wants

3cce4f6

will this sprite be valid pretty please?

4286a29

Does a first pass on noSpawn for all mails.

737b552

ANOTHER COMMIT FOR THE PILE.

MilonPL suggested changes Aug 25, 2024

View reviewed changes

Unfucks noSpawn from the mail prototypes

813e771

MilonPL approved these changes Aug 26, 2024

View reviewed changes

ghost requested review from deltanedas and therealDLondon and removed request for IamVelcroboy August 27, 2024 07:19

github-actions bot added the S: Needs Review label Aug 27, 2024

ghost removed the Changes: Map label Aug 27, 2024

ghost requested review from Lyndomen, A-z-z-y, noctyrnal and Colin-Tel August 31, 2024 03:55

therealDLondon approved these changes Sep 2, 2024

View reviewed changes

deltanedas merged commit 952f368 into DeltaV-Station:master Sep 2, 2024
19 checks passed

Mnemotechnician mentioned this pull request Oct 5, 2024

Feat: Port All Delta-V Mail Improvements Simple-Station/Einstein-Engines#1011

Merged

LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 26, 2025

Try Fix Loadouts, Again (DeltaV-Station#1652)

3417f35

more than likely this is just because of invalid loadouts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Frontier Mail #1652

Frontier Mail #1652

ghost commented Aug 18, 2024 •

edited by ghost

Loading

github-actions bot commented Aug 18, 2024 •

edited

Loading

dvir001 commented Aug 18, 2024

ghost commented Aug 18, 2024 •

edited by ghost

Loading

ghost commented Aug 22, 2024 •

edited by ghost

Loading

ghost commented Aug 22, 2024 •

edited by ghost

Loading

MilonPL left a comment

ghost commented Aug 23, 2024

MilonPL left a comment

ghost commented Aug 25, 2024

ghost commented Aug 26, 2024 •

edited by ghost

Loading

ghost commented Aug 27, 2024 •

edited by ghost

Loading

therealDLondon left a comment

Frontier Mail #1652

Frontier Mail #1652

Conversation

ghost commented Aug 18, 2024 • edited by ghost Loading

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

github-actions bot commented Aug 18, 2024 • edited Loading

dvir001 commented Aug 18, 2024

ghost commented Aug 18, 2024 • edited by ghost Loading

ghost commented Aug 22, 2024 • edited by ghost Loading

ghost commented Aug 22, 2024 • edited by ghost Loading

MilonPL left a comment

Choose a reason for hiding this comment

ghost commented Aug 23, 2024

MilonPL left a comment

Choose a reason for hiding this comment

ghost commented Aug 25, 2024

ghost commented Aug 26, 2024 • edited by ghost Loading

ghost commented Aug 27, 2024 • edited by ghost Loading

therealDLondon left a comment

Choose a reason for hiding this comment

ghost commented Aug 18, 2024 •

edited by ghost

Loading

github-actions bot commented Aug 18, 2024 •

edited

Loading

ghost commented Aug 18, 2024 •

edited by ghost

Loading

ghost commented Aug 22, 2024 •

edited by ghost

Loading

ghost commented Aug 22, 2024 •

edited by ghost

Loading

ghost commented Aug 26, 2024 •

edited by ghost

Loading

ghost commented Aug 27, 2024 •

edited by ghost

Loading