Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does colorama need to be pinned above 0.4.1? #12

Closed
chris2fer opened this issue Dec 13, 2018 · 2 comments
Closed

Does colorama need to be pinned above 0.4.1? #12

chris2fer opened this issue Dec 13, 2018 · 2 comments
Labels
enhancement Improvement to an already existing feature

Comments

@chris2fer
Copy link

The requirement of colorama pinned at 0.4.1 is blocking deploments to AWS lambda because awscli in boto3 has it pinned below 0.3.9. Can this be relaxed?

awscli 1.16.72 has requirement colorama<=0.3.9,>=0.2.5, but you'll have colorama 0.4.1 which is incompatible.

loguru 0.2.2 has requirement colorama>=0.4.1, but you'll have colorama 0.3.9 which is incompatible.

@Delgan
Copy link
Owner

Delgan commented Dec 13, 2018

The v0.4.0 of colarama brings Pycharm support and several other fixes.

I do not know what is the best practice in this case. Should I deliberately downgrade required version although it can cause some bugs to some users?

Anyway, not being able to use loguru on AWS is a problem, thanks for reporting this. I will have to relax colorama required version then.

@Delgan
Copy link
Owner

Delgan commented Dec 16, 2018

I just published version 0.2.3 which downgrade colorama required version to 0.3.4.

I hope it should work now, let me know if you encounter other issues. 😉

@Delgan Delgan closed this as completed Dec 16, 2018
@Delgan Delgan added the enhancement Improvement to an already existing feature label Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an already existing feature
Projects
None yet
Development

No branches or pull requests

2 participants