Fix export atlas to single file PDF #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DelazJ Could you check this ? |
|
Yep, I'll try to give it a test in upcoming days. I already had issues with this (see 212ef55 and I think i tested something else in the past 😭 ) and I'm not really sure of the state of this property |
|
Normalement avec le fix upstream, il y a moyen de virer la condition sur le ˋNoneˋ. Par défaut, la checkbox est check mais la custom property n'est pas initialisée (cf. L'issue QGIS) donc None = True J'ai pas testé des anciennes versions de QGIS pour voir sur la custom property était un string ou booléen... Pour avoir testé ce fix sur la 3.16 et la 3.20, il fonctionne. |
|
Tested and works for me too. Thanks @nicogodet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44