[FIX] Handle case where open is called before refs initialize #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for holding it so long, there are some other stuffs that I must look into. 😅 I will check it first, thank you 😃 |
|
I have already checked it and it works perfectly. Ready to merged. Thank you for your contribution! @awinograd |
|
Glad the PR was useful. Thanks for checking it out and merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @RayAndrews,
This fix is working for me locally. I wasn't able to figure out why the ref callbacks / componentDidMount didn't fire in the order as expected.
Fixes #5