-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postcss-import upgrade for 14.0. #53003
Conversation
Hey @ytetsuro, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
@ytetsuro Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 31 days — it is considered abandoned, and therefore closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53003,
"author": "ytetsuro",
"headCommitOid": "1c798d842cd8aa97c4a5adbd9c2d559fa6376cef",
"lastPushDate": "2021-06-12T01:17:47.000Z",
"lastActivityDate": "2021-06-12T01:17:47.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "postcss-import",
"kind": "edit",
"files": [
{
"path": "types/postcss-import/index.d.ts",
"kind": "definition"
},
{
"path": "types/postcss-import/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/postcss-import/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.lib.0`)"
}
],
"owners": [
"remcohaszing"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "G-Rath",
"date": "2021-05-28T06:27:35.000Z",
"abbrOid": "21b7e27"
}
],
"mainBotCommentID": 842447895,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/1c798d842cd8aa97c4a5adbd9c2d559fa6376cef/checks?check_suite_id=2976796484"
} |
🔔 @remcohaszing — please review this PR in the next few days. Be sure to explicitly select |
@ytetsuro The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - the CI failure looks unrelated to your change (ping @DanielRosenwasser - I'm keen to get this across the line because I'm implementing support for TypeScript configs into postcss-load-config
).
If you add a test, it should let us auto-merge provided CI comes right :)
The CI failure is related. I think |
@ytetsuro The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Thanks, response. https://github.com/DefinitelyTyped/DefinitelyTyped/pull/53003/checks?check_run_id=2807683200 |
@ytetsuro The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@ytetsuro I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jul 12th (in a week) if the issues aren't addressed. |
@ytetsuro To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you! |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
If removing a declaration:
notNeededPackages.json
.