Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postcss-import upgrade for 14.0. #53003

Closed
wants to merge 2 commits into from

Conversation

ytetsuro
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label May 17, 2021
@typescript-bot
Copy link
Contributor

Hey @ytetsuro,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

typescript-bot commented May 17, 2021

@ytetsuro Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53003,
  "author": "ytetsuro",
  "headCommitOid": "1c798d842cd8aa97c4a5adbd9c2d559fa6376cef",
  "lastPushDate": "2021-06-12T01:17:47.000Z",
  "lastActivityDate": "2021-06-12T01:17:47.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "postcss-import",
      "kind": "edit",
      "files": [
        {
          "path": "types/postcss-import/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/postcss-import/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/postcss-import/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.lib.0`)"
        }
      ],
      "owners": [
        "remcohaszing"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "G-Rath",
      "date": "2021-05-28T06:27:35.000Z",
      "abbrOid": "21b7e27"
    }
  ],
  "mainBotCommentID": 842447895,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/1c798d842cd8aa97c4a5adbd9c2d559fa6376cef/checks?check_suite_id=2976796484"
}

@typescript-bot
Copy link
Contributor

🔔 @remcohaszing — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

ytetsuro added a commit to ytetsuro/sabik that referenced this pull request May 17, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 17, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented May 17, 2021

@ytetsuro The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - the CI failure looks unrelated to your change (ping @DanielRosenwasser - I'm keen to get this across the line because I'm implementing support for TypeScript configs into postcss-load-config).

If you add a test, it should let us auto-merge provided CI comes right :)

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label May 28, 2021
@remcohaszing
Copy link
Contributor

The CI failure is related. I think es6 should be replaced with es2018 in tsconfig.json.

@typescript-bot typescript-bot added Check Config Changes a module config files and removed Other Approved This PR was reviewed and signed-off by a community member. The CI failed When GH Actions fails labels Jun 12, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 12, 2021
@typescript-bot
Copy link
Contributor

@ytetsuro The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. and removed Check Config Changes a module config files labels Jun 12, 2021
@ytetsuro
Copy link
Contributor Author

@remcohaszing

I think es6 should be replaced with es2018 in tsconfig.json.

Thanks, response.
I did this, but the CI failed.

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/53003/checks?check_run_id=2807683200

@typescript-bot typescript-bot added Check Config Changes a module config files and removed Other Approved This PR was reviewed and signed-off by a community member. The CI failed When GH Actions fails labels Jun 12, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 12, 2021
@typescript-bot
Copy link
Contributor

@ytetsuro The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 6, 2021

@ytetsuro I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jul 12th (in a week) if the issues aren't addressed.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Jul 6, 2021
@typescript-bot
Copy link
Contributor

@ytetsuro To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Check Config Changes a module config files The CI failed When GH Actions fails Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants