-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use psycopg2 instead of psycopg2-binary. #6858
Conversation
There was some talk about moving to psycopg3 recently. That may be the better approach here |
I agree with @Maffooch - if we're going to change how we handle that dependency, might as well upgrade to psycopg3 |
I'm not familiar enough with the DefectDojo codebase to make that change, since I believe the APIs aren't compatible, so someone else will have to take that on. :) |
@Ayrx thank you for your PR, we're going to work internally on going to psycops3, so I think adding the binary is moving in the wrong direction. |
It occured to me that you will have the same issue with psyocpg3. The recommended installation method for production sites is the local installation method which still requires https://www.psycopg.org/psycopg3/docs/basic/install.html#local-installation |
@Ayrx so? are you modifying your PR to switch to |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psycopg3 is not ready for Django yet, so this is a good step in the right direction :)
Thanks @Maffooch for doing the research on this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This PR changes DefectDojo to use the
psycopg2
package instead ofpsycopg2-binary
.This fixes a problem with running DefectDojo on
aarch64
machines, with the main motivation here being able to do dev work on an Apple Silicon Macbook.The
psycopg2
package also recommends build from source instead of relying on the binary package.