Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotate and poisson #69

Merged
merged 5 commits into from
Dec 15, 2024
Merged

Fix rotate and poisson #69

merged 5 commits into from
Dec 15, 2024

Conversation

m-reuter
Copy link
Member

  1. when computing a function with rotated gradients, the problem was singular due to the degree of freedom to shift the function (addition of constant). This can be fixed by specifying an arbitrary dirichlet boundary condition at a vertex (here: 0, 0.0).
  2. in poisson, when a function h was passed in connection with a dirichlet boundary condition, the function h needs to be a 2D matrix with a single column instead of a 1-dim vector. So we add a new axis.

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.89%. Comparing base (109511c) to head (ed4e433).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
lapy/diffgeo.py 0.00% 2 Missing ⚠️
lapy/plot.py 0.00% 1 Missing ⚠️
lapy/solver.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   34.89%   34.89%   -0.01%     
==========================================
  Files          14       14              
  Lines        2367     2370       +3     
  Branches      299      286      -13     
==========================================
+ Hits          826      827       +1     
- Misses       1457     1458       +1     
- Partials       84       85       +1     
Flag Coverage Δ
unittests 34.89% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-reuter m-reuter merged commit 2cbcee0 into main Dec 15, 2024
26 of 28 checks passed
@m-reuter m-reuter deleted the fix-rotate branch December 15, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant