Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getscale for f_low != 0 (default value) #506

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix getscale for f_low != 0 (default value) #506

merged 1 commit into from
Apr 17, 2024

Conversation

dkuegler
Copy link
Member

@dkuegler dkuegler commented Apr 8, 2024

  • As reported in conform.py bug #505 , getscale unexpectedly corrupts src_max (via src_min), if f_low is not 0.0 (the default value).
  • Updated variable names, formatting, comments
  • Optimized double calls to min and max (explicitly getscale and implicitly via np.histogram).

TODO:

  • Needs testing, i.e. test whether results for current and old implementation are the same based on mri_diff evaluation.

@dkuegler
Fix getscale for f_low != 0 (default value)
95a559d 
- As reported in Deep-MI#505, getscale unexpectedly corrupts src_max (via src_min), if f_low is not 0.0 (the default value).
- Updated variable names, formatting, comments
- Optimized double calls to min and max (explicitly getscale and implicitly via np.histogram).
@dkuegler dkuegler marked this pull request as ready for review April 17, 2024 14:10
@dkuegler dkuegler requested a review from m-reuter April 17, 2024 14:10
@dkuegler
Copy link
Member Author

Tested and same output confirmed

@m-reuter m-reuter merged commit 9b02a98 into Deep-MI:dev Apr 17, 2024
2 checks passed
@dkuegler dkuegler mentioned this pull request Apr 17, 2024
Closed
@dkuegler dkuegler deleted the fix/conform branch April 20, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-reuter m-reuter Awaiting requested review from m-reuter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkuegler @m-reuter