Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest lapy #12

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Update to latest lapy #12

merged 5 commits into from
Jun 19, 2023

Conversation

kdiers
Copy link
Collaborator

@kdiers kdiers commented Jun 19, 2023

  • Incorporated importing and syntax changes to be compatible with lapy 1.0.0.
  • I suggest to increment the brainprint version to at least 0.3.1 to maintain distinguishable versions.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@1150253). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   27.19%           
=======================================
  Files           ?        8           
  Lines           ?      353           
  Branches        ?       43           
=======================================
  Hits            ?       96           
  Misses          ?      255           
  Partials        ?        2           
Flag Coverage Δ
unittests 27.19% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kdiers
Copy link
Collaborator Author

kdiers commented Jun 19, 2023

  • Maybe consider specifying lapy>=1.0.0 requirement in pyproject.toml if that's possible.
  • Please check version given in pyproject.toml (currently 0.4.0-dev) - is that correct?

from lapy import TriaIO, TriaMesh
from lapy.read_geometry import read_geometry
from lapy import TriaMesh
from lapy._read_geometry import read_geometry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed here (and should not be used as it is an internal module). Instead in line 179 you can just load the TriaMesh with TriaMesh.read_fssurf and then save it again mit write_vtk.

@m-reuter
Copy link
Member

m-reuter commented Jun 19, 2023

  • Maybe consider specifying lapy>=1.0.0 requirement in pyproject.toml if that's possible.

specifying the version should be possible, not sure what the exact formatting is, but you should do that. I think you can specify:
lapy = "^1.0.0"
(or 1.* or ~1 ) which in our case are all the same meaning we allow anything >= 1.0 and < 2.0. Maybe use the ^ character as it means upward until the first non-zero number changes.

  • Please check version given in pyproject.toml (currently 0.4.0-dev) - is that correct?

yes, 0.3.0 is our last release so dev is now 0.4.0-dev until we release 0.4 .

@m-reuter m-reuter merged commit e74b3a3 into main Jun 19, 2023
@m-reuter m-reuter deleted the update_to_latest_lapy branch June 19, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants