-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest lapy #12
Conversation
kdiers
commented
Jun 19, 2023
- Incorporated importing and syntax changes to be compatible with lapy 1.0.0.
- I suggest to increment the brainprint version to at least 0.3.1 to maintain distinguishable versions.
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage ? 27.19%
=======================================
Files ? 8
Lines ? 353
Branches ? 43
=======================================
Hits ? 96
Misses ? 255
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
brainprint/surfaces.py
Outdated
from lapy import TriaIO, TriaMesh | ||
from lapy.read_geometry import read_geometry | ||
from lapy import TriaMesh | ||
from lapy._read_geometry import read_geometry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed here (and should not be used as it is an internal module). Instead in line 179 you can just load the TriaMesh with TriaMesh.read_fssurf and then save it again mit write_vtk.
specifying the version should be possible, not sure what the exact formatting is, but you should do that. I think you can specify:
yes, 0.3.0 is our last release so dev is now 0.4.0-dev until we release 0.4 . |