v3 audit2 #68
v3 audit2 #68
Conversation
|
|
||
| <a name="m01"></a> | ||
|
|
||
| ## M01 - ProtocolAmount is not enforced, allowing users to bypass protocol fees |
There was a problem hiding this comment.
In the context of payment validation, the protocolAmount (fee) is intended to be enforced during post-payment validation. It is not necessary to enforce this fee at the smart contract level, as the design allows for flexibility in handling payments with or without a protocolAmount (fee). This approach is intentional, ensuring that payments can be processed even when no protocol fee is required.
|
|
||
| <a name="i01"></a> | ||
|
|
||
| ## I01 - Inconsistent time units used for deadlines (milliseconds vs seconds) |
There was a problem hiding this comment.
The use of deadline in milliseconds is explicitly documented both in the source code and accompanying documentation. The requirement for deadline in milliseconds serves a specific purpose: it allows for the creation of a more unique index that includes the payment sender (from), payment receiver (to), and the deadline. This ensures that payments made within the same second are distinguishable, providing a unique index for validation and preventing duplicate payments in time-sensitive scenarios.
No description provided.