Feat/light curve sas generation #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the docs rst. For issue #970
…een spectrum and lightcurve generation
…es using evselect has been implemented - no modification to sas_call has been made, and no XGA product exists to house the lightcurves however. For issue #970
…sion of the pattern
…es to hopefully get the evselect_lightcurve function working. For issue #970
…he way I wanted integer patterns to be treated
… the options I was passing to the lc correction routine, I misread it from the manual. In this commit the generation commands for the debug images are commented out. For issue #970
… the sas execute_cmd function will setup LightCurve instances. For issue #971
…dded to the extra name information for the LC files. Seems to have cleared up the generation issues. For issue #970
…he central coordinate and size of the generation region. Also added the automatic creation of storage keys to the LightCurve class. For issue #971
…cribing the central coord and radii of the region. For issue #971
…m disk into memory on demand, and has properties for those data. For issue #971
…om the light curve fits file. For issue #971
…racted, source, and background light curves separately. Also have a first pass at a view method. Need to do error propagation to get good bck sub or src count rates (depending on input), shouldn't take much implementing. For issue #971
… class. For issue #971
… class, and highlight the GTI in green for clarity. For issue #971
…tted properly. For issue #971
…k of how it would be triggered there..) and it was breaking spectrum fitting. Added the default NUM_CORES to the signature to fix that
…n demand if they needed too - also added datetime, start_datetime, and stop_datetime properties to LightCurve
…very nearly there. Now experimenting with offsetting the x axis tick labels so I can get an x axis label in between the axis line and the tick labels
…tCurve can live outside the axis as it is meant too now
…gle GTI light curves
…ful errors to get_lightcurves, and made sure that the src name is set in the init of aggregate light curve
… aggregate light curve
… curve in the right place - also making sure that the x-axis tick labels are altered to dates regardless of whether there are data for the requested instrument
…t curve already exists - also corrected an error where I was leaving the unit in the radius search string and thus it was not working
…-use a lot of it for get_aggregate lightcurves or whatever I end up calling it
…ttern strings being passed in
…hey couldn't read the files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.