Feat/cross arf generation and storage #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up for cross arf generation. For issue #917
…elete the files after it has generated them (sigh). Also corrected a small bug where XGA would have been looking in the temporary directory for the final files. For issue #917
…on_setup function there. I also added a first pass at a separate function for the generation of detmap commands. This will initially be used in cross_arfs, but also will eventually be used in the spectrum command generation section. For issue #917
…-arfs. The default is now set to 200, rather than the 100 which is used in spectrum generation (and is currently not user configurable). That has definitely sped up the calculation of cross-arfs. I'd say 200 is a reasonable default value. For issue #917
… info for each generation task. This will help us pass the cross arfs to the annular spectra. For issue #917
…used to generate a particular cross-arf to the extra_info. For issue #917
… should work this time around as I should have removed the annulus-identifying bug in my recent completion of the 'view spectra properly' branch. For issue #917
… cases like cross-arf generation were cross-arfs are being put in BaseProduct instances so they can be returned from execute_cmd in the existing framework. THis extra info argument will let me store stuff like the set_ident, annuli identifiers, etc. For issue #917
…quested detector maps already exist. For issue #917
… actually fixed now. For issue #917
…p generation commands, as I would forget to do it otherwise. Indirectly for issue #917
…e cross-arfs and store them in the correct annular spectrum. For issue #917
…om the cross-arfs. For issue #1010
…etrieve a specific path instead of a set of them. Indirectly for issue #1010
…ill do some more testing first
… altered the minimum y value for when we're plotting normalised curves. For issue #1010
…-arfs. Currently just a copy of my original generalised XSPEC fit template, but with a message indicating it doesn't do anything and an exit. This will be developed in tandem with the Python interface, to make it easier to test, also I need to re-learn TCL again. For issue #917
…tly safer. For issue #917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.