Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13 view dv session #24

Merged
merged 6 commits into from
May 7, 2024
Merged

13 view dv session #24

merged 6 commits into from
May 7, 2024

Conversation

HatePK
Copy link

@HatePK HatePK commented May 4, 2024

  • базовая верстка
  • атрибуты кастом класса
  • класс SessionView
  • добавление сампла

@HatePK HatePK requested a review from n-shvedov27 as a code owner May 4, 2024 19:21
@HatePK HatePK requested review from GoetzDeBouville and DimaK21 May 4, 2024 19:22
@HatePK HatePK linked an issue May 4, 2024 that may be closed by this pull request
Кастомная view DVSession #13
Open
GoetzDeBouville
GoetzDeBouville suggested changes May 5, 2024
View reviewed changes
Copy link
Contributor

@GoetzDeBouville GoetzDeBouville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оставил комменты, из критичного - большая вложенность в макете кастомной вью, этого следует избегать

@n-shvedov27 n-shvedov27 merged commit 2b5c061 into develop May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoetzDeBouville GoetzDeBouville GoetzDeBouville approved these changes

@n-shvedov27 n-shvedov27 n-shvedov27 approved these changes

@DimaK21 DimaK21 DimaK21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Кастомная view DVSession
4 participants
@HatePK @GoetzDeBouville @n-shvedov27 @DimaK21