domain_history: fix false negative results #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netcraft is heavily reliant upon javascript to check for automated scraping and rendering of the page. Switching over to selinium from requests and rendering the page with either PhantomJS, Chrome or Firefox circumvents this issue and actually returns results if present.
You can see the proof of this issue by printing out the BeautfiulSoup response in the unpatched module
If the user ignores the instructions and somehow PhantomJS, Chrome or Firefox aren't installed on the system, this module will spit out a selenium error that I can't catch and redirect. However, the error will not cause datasploit (or anything else) to hard fail/exit. So, I figure this rare edge case issue is mostly acceptable and far more acceptable/expected than 100% false negative results.