MaaS model correct conversion

[Nicolas-Boltz]

Add MaaS model and tmp test code

[uuqjz]

Ive removed the additional test function and replaced it with this line:
testSpecificModel("MaaS_Ticket_System_base", "MaaS", modelLocation, "maas.json", null);
As expected the existing tests fail for maas, indicating inconsistencies

[uuqjz]

Ive also added the CWA so we can check when the converters is fixed that all test pass on TravelPlanner, MaaS and CWA

[uuqjz]

Ive fixed the existing tests, so that they run on TravelPlanner, CWA and MaaS. This doesn't solve the issue with the missing behaviour but makes a better starting point

[uuqjz]

Forwarding works now correctly

[uuqjz]

@Nicolas-Boltz For Normal assignments: Shall i just set the node charactersits at every outpin? Akin to the micro converter

[uuqjz]

@01Parzival10 @Entenwilli I am done fixing small stuff, you can review this PR now.

[Entenwilli]

Currently, this PR is hard to evaluate, as assigning a forward assignment to every node (including the PCM Source Node) will lead to no TFGs as the finder cannot determine a source and recurses endlessly

[Entenwilli]

Some smaller review comments, overall it looks good

[01Parzival10]

Currently, this PR is hard to evaluate, as assigning a forward assignment to every node (including the PCM Source Node) will lead to no TFGs as the finder cannot determine a source and recurses endlessly

Is this an actual issue tho? Are the DFD's created by the Converter actually supposed to be put into the analysis again?

Because #170 will not solve this. It will probably lead to single node unconnected TFG's since All the assignments will be independent of their input pins

[Entenwilli]

Hmm, also true.... From what I have gathered so far, the created DFD seems fine, so there is no need to look at the TFGs of the generated model

[uuqjz]

The DFDs created by the converter are put back into the (dfd)analysis that's the whole point.
For microsecend this works just fine, and i thought with the changes of #170 it should work for pcm too

[Entenwilli]

The DFDs created by the converter are put back into the (dfd)analysis that's the whole point. For microsecend this works just fine, and i thought with the changes of #170 it should work for pcm too

If @01Parzival10 is correct (and I agree he is), DataFlowAnalysis/DataFlowAnalysis#170 will indeed not fix this. To get usable TFGs from the Finder, Forwarding Assignments are most likely needed

[uuqjz]

Lets discuss that tomorrow and adress it in a separate PR.
So that this one just contains the fix and can be merged

[uuqjz]

@01Parzival10 Shall i wait for your review?