Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 - New Assignments and Behavior Name Change #25

Merged
merged 9 commits into from
Dec 10, 2024
Merged

4.0 - New Assignments and Behavior Name Change #25

merged 9 commits into from
Dec 10, 2024

Conversation

01Parzival10
Copy link
Contributor

@01Parzival10 01Parzival10 commented Dec 3, 2024

Added handling for new Assignments to Web2DFD and DFD2Web Converter
Adjusted Web2DFD and DFD2Web Converter to new Assignment semantic
Adjusted Behavior Naming where necessary
New tests for new Assignments

!!Forth Merge of 4.0 - Do DataFlowAnalysis first!!

@01Parzival10 01Parzival10 added the enhancement New feature or request label Dec 3, 2024
@01Parzival10 01Parzival10 self-assigned this Dec 3, 2024
@01Parzival10
Copy link
Contributor Author

Nicolas-Boltz
Nicolas-Boltz previously approved these changes Dec 10, 2024
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with the 3. PR. Please re-run the build action of this PR once more after the previous PRs have been merged, just to be sure.

.filter(flow -> flow.getDestinationNode().equals(node))
.filter(flow -> flow.getEntityName().equals("")).toList();

String controlFlowName = "" + CONTROL_FLOW_NAME;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt you do this code in a previous PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to run some tests i also copied it over to this branch

@01Parzival10 01Parzival10 removed their assignment Dec 10, 2024
Copy link
Collaborator

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMN

@01Parzival10 01Parzival10 merged commit 3090b70 into main Dec 10, 2024
1 check passed
@01Parzival10 01Parzival10 deleted the 4.0 branch December 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants