Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DFD and Web Converter #22

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Split DFD and Web Converter #22

merged 2 commits into from
Oct 31, 2024

Conversation

uuqjz
Copy link
Collaborator

@uuqjz uuqjz commented Oct 23, 2024

This PR splits the 750 loc DFDConverter into a DFDConverter (dfdToWeb) and a WebEditorConverter(webToDfd)

@01Parzival10
Copy link
Contributor

I suggest moving the storeWeb method from the DataFlowDiagramConverter to the Converter class and making it static.

Or move the storeDFD method to the WebEditorConverter Class and get completely rid of the Converter class.

@uuqjz
Copy link
Collaborator Author

uuqjz commented Oct 25, 2024

I suggest moving the storeWeb method from the DataFlowDiagramConverter to the Converter class and making it static.

Or move the storeDFD method to the WebEditorConverter Class and get completely rid of the Converter class.

storeDFDis also used by the PCM converter. So I'd rather go with the first option

@uuqjz
Copy link
Collaborator Author

uuqjz commented Oct 29, 2024

@01Parzival10 Done.

Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it was a very wise decision to split up the editor.

@uuqjz uuqjz merged commit b03c858 into main Oct 31, 2024
1 check passed
@uuqjz uuqjz deleted the split-dfd-converter branch October 31, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split WebToDfd and DfdToWeb in seperate classes
3 participants