Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter fix #2

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Converter fix #2

merged 4 commits into from
Jun 12, 2024

Conversation

01Parzival10
Copy link
Contributor

No description provided.

@01Parzival10 01Parzival10 requested a review from uuqjz June 12, 2024 11:14
@01Parzival10 01Parzival10 mentioned this pull request Jun 12, 2024
Copy link
Collaborator

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a leftover debugging variable

@@ -92,6 +92,9 @@ private void testSpecificModel(String inputModel, String inputFile, String model
if (complete == null) {
complete = new PCMConverter().pcmToDFD(modelLocation, usageModelPath, allocationPath, nodeCharPath, Activator.class);
}

final DataFlowDiagram test = complete.dataFlowDiagram();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatfor do you need this test variable?

Copy link
Collaborator

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGNTM

@uuqjz uuqjz merged commit 217b327 into main Jun 12, 2024
1 check passed
@uuqjz uuqjz deleted the ConverterFix branch June 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants