-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[security_monitoring_rule] Support Third Party rules #2231
Merged
nkzou
merged 10 commits into
master
from
pietrodll/security-monitoring-third-party-cases
Jan 16, 2024
Merged
[security_monitoring_rule] Support Third Party rules #2231
nkzou
merged 10 commits into
master
from
pietrodll/security-monitoring-third-party-cases
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion method Add Terraform resources for third party cases and options.
…ity function to clarify code
pietrodll
force-pushed
the
pietrodll/security-monitoring-third-party-cases
branch
from
January 8, 2024 13:43
6744f40
to
5bbcee0
Compare
daniel-trinh
previously approved these changes
Jan 8, 2024
brett0000FF
previously approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some nits from Docs.
pietrodll
dismissed stale reviews from brett0000FF and daniel-trinh
via
January 9, 2024 10:27
add3f61
… the security monitoring data source as integration only due to unreasonably large http interaction
daniel-trinh
previously approved these changes
Jan 10, 2024
brett0000FF
previously approved these changes
Jan 10, 2024
nkzou
reviewed
Jan 10, 2024
nkzou
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Cloud SIEM third party detection rules.
datadog-api-client-go
to include Security Monitoring - Support custom third party rules datadog-api-client-go#2337third_party_case
third_party_rule_options
parseStringArray
to convert[]interface{}
to[]string