Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security_monitoring_rule] Support Third Party rules #2231

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

pietrodll
Copy link
Contributor

@pietrodll pietrodll commented Jan 8, 2024

Add support for Cloud SIEM third party detection rules.

@pietrodll pietrodll requested review from a team as code owners January 8, 2024 13:28
@pietrodll pietrodll requested a review from a team as a code owner January 8, 2024 13:33
@pietrodll pietrodll force-pushed the pietrodll/security-monitoring-third-party-cases branch from 6744f40 to 5bbcee0 Compare January 8, 2024 13:43
daniel-trinh
daniel-trinh previously approved these changes Jan 8, 2024
brett0000FF
brett0000FF previously approved these changes Jan 8, 2024
Copy link

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some nits from Docs.

docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
docs/resources/service_level_objective.md Outdated Show resolved Hide resolved
docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
@pietrodll pietrodll dismissed stale reviews from brett0000FF and daniel-trinh via add3f61 January 9, 2024 10:27
pietrodll and others added 2 commits January 9, 2024 15:39
… the security monitoring data source as integration only due to unreasonably large http interaction
daniel-trinh
daniel-trinh previously approved these changes Jan 10, 2024
brett0000FF
brett0000FF previously approved these changes Jan 10, 2024
@nkzou nkzou dismissed stale reviews from brett0000FF and daniel-trinh via c1dbe1e January 10, 2024 21:57
@nkzou nkzou merged commit ed76f9b into master Jan 16, 2024
9 checks passed
@nkzou nkzou deleted the pietrodll/security-monitoring-third-party-cases branch January 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants