[apm_retention_filters] Add resources and datasource #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9de1a5c to
8b8e191
Compare
skarimo
reviewed
Nov 10, 2023
datadog/fwprovider/data_source_datadog_apm_retention_filters_order.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/data_source_datadog_apm_retention_filters_order.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/data_source_datadog_apm_retention_filters_order.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_apm_retention_filter_order.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_apm_retention_filter_order.go
Outdated
Show resolved
Hide resolved
aliciascott
previously approved these changes
Nov 10, 2023
skarimo
reviewed
Nov 15, 2023
skarimo
reviewed
Nov 15, 2023
datadog/fwprovider/resource_datadog_apm_retention_filter_order.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_apm_retention_filter_order.go
Outdated
Show resolved
Hide resolved
skarimo
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds terraform support to control APM retention filters.
The newly added resources are:
apm_retention_filterto maintain individual retention filters.apm_retention_filter_orderto maintain the execution order for retention filters.The newly added datasource is:
apm_retention_filters_orderto get the current order.depends on DataDog/datadog-api-client-go#2172 to be released