Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Remove special handling of GraphQL response status code #3843

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 17, 2025

Motivation

We are changing the way we are doing blocking for GraphQL in Ruby:
DataDog/dd-trace-rb#4300

https://datadoghq.atlassian.net/browse/APPSEC-56464

Changes

This PR removes special case for response status code assertion for Ruby when GraphQL response is being blocked.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Jan 17, 2025
@y9v y9v changed the title Remove special case for ruby GraphQL response status code Ruby: Remove special handling of GraphQL response status code Jan 20, 2025
@y9v y9v force-pushed the appsec-remove-graphql-status-code-exception-for-ruby branch from 0305a3d to a11a573 Compare January 20, 2025 17:09
@y9v y9v force-pushed the appsec-remove-graphql-status-code-exception-for-ruby branch from ce5822a to c584e19 Compare January 20, 2025 17:47
@y9v y9v force-pushed the appsec-remove-graphql-status-code-exception-for-ruby branch from c584e19 to eaa1db7 Compare January 21, 2025 07:47
@cbeauchesne
Copy link
Collaborator

FYI, when only ruby is impacted, you can prefix with [ruby] (with square brackets), it'll run only ruby jobs.

side note, PHP failures are not related

@y9v y9v changed the title Ruby: Remove special handling of GraphQL response status code [ruby] Remove special handling of GraphQL response status code Jan 21, 2025
@y9v y9v marked this pull request as ready for review January 21, 2025 08:59
@y9v y9v requested review from a team as code owners January 21, 2025 08:59
@y9v y9v merged commit 618cf56 into main Jan 21, 2025
267 of 291 checks passed
@y9v y9v deleted the appsec-remove-graphql-status-code-exception-for-ruby branch January 21, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants