[python] build with ucs4 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
reviewed
Apr 17, 2018
config/software/python.rb
Outdated
| @@ -37,6 +37,7 @@ | |||
| } | |||
|
|
|||
| python_configure = ["./configure", | |||
| "--enable-unicode=ucs4", | |||
There was a problem hiding this comment.
can we do this on Linux only? The default python on macOS is still built with ucs2, and the homebrew-provided python too, see Homebrew/homebrew-core#12510
olivielpeau
suggested changes
Jun 4, 2018
| @@ -40,10 +40,12 @@ | |||
| "--enable-universalsdk=/", | |||
| "--prefix=#{install_dir}/embedded"] | |||
|
|
|||
| if ohai["platform_family"] == "mac_os_x" | |||
| if mac_os_x? | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
we have this in multiple recipes though...
There was a problem hiding this comment.
ok this one is actually provided by chef-sugar
There was a problem hiding this comment.
in the future we should probably get rid of our lib/ostools.rb and use the sugar-provided stuff directly instead
olivielpeau
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.