Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify target broker ids in create topic request #400

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Allow to specify target broker ids in create topic request #400

merged 3 commits into from
Apr 22, 2022

Conversation

dopuskh3
Copy link
Contributor

A list of broker ids can be specified in the create topic request
to select brokers on which to create topic.

@dopuskh3 dopuskh3 requested a review from a team April 22, 2022 09:21
@dopuskh3 dopuskh3 force-pushed the francois.visconte/add-target-brokers-registry branch 7 times, most recently from 0dba4e3 to 3d1a8f3 Compare April 22, 2022 13:28
jamiealquiza
jamiealquiza reviewed Apr 22, 2022
View reviewed changes
registry/server/api_topics.go Outdated Show resolved Hide resolved
registry/server/api_topics.go Show resolved Hide resolved
registry/server/api_topics.go Outdated Show resolved Hide resolved
mborst
mborst reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@mborst mborst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we could solve our current use case, and other use cases that might pop up, in a more idiomatic way by adding a batch tagging operation.

registry/server/api_topics.go Outdated Show resolved Hide resolved
@dopuskh3 dopuskh3 force-pushed the francois.visconte/add-target-brokers-registry branch 3 times, most recently from 47d46cd to cc6a3dd Compare April 22, 2022 17:12
@dopuskh3
Allow to specify a list of brokers to create topic on
77e5775 
If broker tag is also passed, takes the intersection of tagged brokers
and specified broker ids.
@dopuskh3 dopuskh3 force-pushed the francois.visconte/add-target-brokers-registry branch from cc6a3dd to 77e5775 Compare April 22, 2022 17:15
@jamiealquiza jamiealquiza merged commit a82ff89 into master Apr 22, 2022
@jamiealquiza jamiealquiza deleted the francois.visconte/add-target-brokers-registry branch May 11, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborst mborst mborst left review comments

@jamiealquiza jamiealquiza jamiealquiza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dopuskh3 @jamiealquiza @mborst