Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jmxfetch] option should be min_collection_interval in the YAML. #140

Merged
merged 3 commits into from
May 31, 2017
Merged

[jmxfetch] option should be min_collection_interval in the YAML. #140

merged 3 commits into from
May 31, 2017

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented May 31, 2017

No description provided.

@olivielpeau
Copy link
Member

I think there's a test that needs an update too:
https://github.com/DataDog/jmxfetch/blob/7cf612c454088f7bf758d6bed6f99550fd84b5a9/src/test/java/org/datadog/jmxfetch/TestInstance.java and https://github.com/DataDog/jmxfetch/blob/7cf612c454088f7bf758d6bed6f99550fd84b5a9/src/test/resources/jmx_min_collection_period.yml ;)

@gmmeyer
Copy link
Contributor

gmmeyer commented May 31, 2017

@olivielpeau ah ha you're right!

@truthbk
Copy link
Member Author

truthbk commented May 31, 2017 •
edited
Loading

Merging now that CI is back to 💚

@truthbk truthbk merged commit 38dce00 into master May 31, 2017
@truthbk truthbk deleted the jaime/renameival branch May 31, 2017 20:45
@olivielpeau olivielpeau modified the milestones: 0.13.1, 0.14.0 May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@truthbk @olivielpeau @gmmeyer